After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707619 - Destroying the list or icon view leads to a crash
Destroying the list or icon view leads to a crash
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.9.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
: 725547 726758 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-06 10:42 UTC by Branko Grubic (bitlord)
Modified: 2014-03-22 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backtrace (26.34 KB, application/octet-stream)
2013-09-06 10:42 UTC, Branko Grubic (bitlord) 		  Details
build: update to latest libgd (586 bytes, patch)
2013-09-06 16:10 UTC, Carl-Anton Ingmarsson 		committed Details | Review
build: Update libgd to fix a crash when the list view is destroyed (578 bytes, patch)
2014-03-22 13:17 UTC, Debarshi Ray 		committed Details | Review

Description Branko Grubic (bitlord) 2013-09-06 10:42:35 UTC 
Created attachment 254242 [details]
backtrace

I'm using gnome-documents-3.9.91-1.fc20.x86_64  and when I close it it triggers gjs-console crash. 
I don't like abrt much, so I tried to recreate backtrace with a gdb + coredump, If needed more debuginfo I can install.
Comment 1 Carl-Anton Ingmarsson 2013-09-06 16:10:10 UTC 
Created attachment 254272 [details] [review]
build: update to latest libgd

Fixes crash when window is closed.
Comment 2 Carl-Anton Ingmarsson 2013-09-06 16:12:06 UTC 
Note that it now doesn't shutdown until after 12 seconds after the window is closed due to the (deliberate) setting of inactivity_timeout to 12 seconds at application.js:107
Comment 3 Cosimo Cecchi 2013-09-06 16:13:14 UTC 
Review of attachment 254272 [details] [review]:

Looks good to me, thanks.
Comment 4 Carl-Anton Ingmarsson 2013-09-06 17:13:15 UTC 
Attachment 254272 [details] pushed as 0c748e4 - build: update to latest libgd
Comment 5 Debarshi Ray 2014-03-22 13:06:59 UTC 
*** Bug 726758 has been marked as a duplicate of this bug. ***
Comment 6 Debarshi Ray 2014-03-22 13:08:14 UTC 
This only fixes it for the icon view. We need one more libgd commit to fix it for the tree view.

commit 41820ae96142312ffc0109b65d2adad6f007e1fd
Author: Pierre-Yves Luyten <py@luyten.fr>
Date:   Tue Oct 22 21:33:07 2013 +0200

    list-view: Don't clear attributes on no model
    
    No point in clearing the existing attributes in set_attributes_from_model
    if we are not going to actually set any
Comment 7 Debarshi Ray 2014-03-22 13:15:09 UTC 
*** Bug 725547 has been marked as a duplicate of this bug. ***
Comment 8 Debarshi Ray 2014-03-22 13:17:02 UTC 
Created attachment 272628 [details] [review]
build: Update libgd to fix a crash when the list view is destroyed
Comment 9 Debarshi Ray 2014-03-22 13:21:56 UTC 
Changing the summary a bit. Closing the application is not the only time it crashes. It also crashes if you flip the grid/list toggle when there is no content. See bug 725547
Comment 10 Cosimo Cecchi 2014-03-22 19:24:39 UTC 
Review of attachment 272628 [details] [review]:

Looks good
Comment 11 Debarshi Ray 2014-03-22 19:28:02 UTC 
This (actually bug 726758) was marked as a 3.12 blocker, and the release team gave permission for a hard code freeze break, so I am pushing this particular patch.
Comment 12 Debarshi Ray 2014-03-22 19:31:41 UTC 
Comment on attachment 272628 [details] [review]
build: Update libgd to fix a crash when the list view is destroyed

Thanks for the quick review, Cosimo.