Created attachment 254179 [details] [review]
sysdeps: Search C include files in multiarch subdirectories

Since version 3.9.7-2 of the libtiff4-dev Debian package, the tiff.h
header file has been moved to /usr/include/x86_64-linux-gnu/tiff.h and
jhbuild was unable to detect its availability when checking for system
dependencies.

Adding "/usr/include/`gcc -print-multiarch`" to the search paths fixes
the problem.

Did you run 'jhbuild bootstrap' and build pkg-config in jhbuild?  If it's so, you should remove all of it and use pkg-config from Debian, that won't have that problem.

No, I've not built pkg-config myself and I'm using the one from Debian, but I don't think this is related to the reported issue.

For the libtiff dependency pkg-config is not used (libtiff doesn't seem to ship any .pc file) and JHBuild directly checks the availability of the tiff.h include file[1].

The code that does the check simply iterates over a list of paths[2] testing if the file exists. The first element of the search paths list is always "/usr/include"[3] and if `gcc -print-multiarch` prints something sensible I just add "/usr/include/`gcc -print-multiarch`" as the second element.

[1] https://git.gnome.org/browse/jhbuild/tree/modulesets/gnome-sysdeps-3.10.modules#n474
[2] https://git.gnome.org/browse/jhbuild/tree/jhbuild/utils/systeminstall.py#n118
[3] https://git.gnome.org/browse/jhbuild/tree/jhbuild/utils/systeminstall.py#n83

I ran into the same issue, I think Emanuele is right.

His patch looks fine to me.

Thanks Alberto, I plan to push this in a couple of days if noone objects. Frederic, is it fine for you?

Yeah, sorry I didn't follow up; go ahead and push.

The following fix has been pushed:
87b135a sysdeps: Search C include files in multiarch subdirectories

Thanks!