After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707473 - MonitorConfig: remove holes generated by disabling the laptop lid
MonitorConfig: remove holes generated by disabling the laptop lid
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 707478 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-04 14:57 UTC by Giovanni Campagna
Modified: 2013-09-16 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MonitorConfig: remove holes generated by disabling the laptop lid (2.35 KB, patch)
2013-09-04 14:57 UTC, Giovanni Campagna 		committed Details | Review
MonitorConfig: fix hole filling in the laptop lid automatic configuration (1.24 KB, patch)
2013-09-16 14:16 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-09-04 14:57:54 UTC 
No, holes in the framebuffer are not a good a thing: windows can
get lost there, and the user can get very confused.
Instead, compact the monitors that where previously after.
Comment 1 Giovanni Campagna 2013-09-04 14:57:56 UTC 
Created attachment 254096 [details] [review]
MonitorConfig: remove holes generated by disabling the laptop lid
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-09-04 14:59:49 UTC 
Review of attachment 254096 [details] [review]:

OK.
Comment 3 Giovanni Campagna 2013-09-04 15:21:30 UTC 
Attachment 254096 [details] pushed as 0b89e34 - MonitorConfig: remove holes generated by disabling the laptop lid
Comment 4 Giovanni Campagna 2013-09-04 15:24:26 UTC 
*** Bug 707478 has been marked as a duplicate of this bug. ***
Comment 5 Thomas Wood 2013-09-05 10:59:45 UTC 
This hasn't fixed the issue mentioned in bug 707478, since there is still an off-screen area where new windows can be placed and that shows up in screenshots.
Comment 6 Giovanni Campagna 2013-09-16 14:16:56 UTC 
Created attachment 255030 [details] [review]
MonitorConfig: fix hole filling in the laptop lid automatic configuration

Need two passes, because the order we traverse the array is
alphabetical on connector name, not left to right, so we might
see a monitor on the right before we get the offset from disabling
the primary monitor.
Comment 7 Thomas Wood 2013-09-16 15:24:30 UTC 
Review of attachment 255030 [details] [review]:

This seems to fix the issue I was seeing.
Comment 8 Florian Müllner 2013-09-16 20:35:12 UTC 
Review of attachment 255030 [details] [review]:

OK.
Comment 9 Giovanni Campagna 2013-09-16 20:40:01 UTC 
Attachment 255030 [details] pushed as 423bd70 - MonitorConfig: fix hole filling in the laptop lid automatic configuration