After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707461 - Add a man page
Add a man page
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal enhancement
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
available
Depends on:
Blocks:
 
 
Reported: 2013-09-04 12:59 UTC by Arnel Borja
Modified: 2014-06-23 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
man page for Music (996 bytes, text/plain)
2014-05-25 02:33 UTC, Brett 		  Details
proper patch for adding a manpage (1.47 KB, patch)
2014-05-28 22:10 UTC, Brett 		needs-work Details | Review
add man page (1.53 KB, patch)
2014-05-30 05:02 UTC, Brett 		committed Details | Review

Description Arnel Borja 2013-09-04 12:59:20 UTC 
Add a simple man page. Without this, rpmlint and lintian gives out warnings when building rpm and deb packages.
Comment 1 Allan Day 2014-04-22 19:41:00 UTC 
Yep, it's important to have a man page.
Comment 2 Brett 2014-05-25 02:33:41 UTC 
Created attachment 277134 [details]
man page for Music

Here is a small manpage I wrote that might prove useful.
Comment 3 Brett 2014-05-25 02:34:55 UTC 
Comment on attachment 277134 [details]
man page for Music

change from binary to text
Comment 4 Vadim Rutkovsky 2014-05-28 09:32:18 UTC 
(In reply to comment #3)
> (From update of attachment 277134 [details])
> change from binary to text

Brett, could you use "git format-patch" for this - otherwise author and commit message are getting lost and we can't review it in bugzilla. See https://wiki.gnome.org/Git/WorkingWithPatches#How_to_make_a_patch for more details
Comment 5 Brett 2014-05-28 22:10:07 UTC 
Created attachment 277421 [details] [review]
proper patch for adding a manpage

I'm sorry for the trouble. Here you are.
Comment 6 Vadim Rutkovsky 2014-05-29 08:48:36 UTC 
Review of attachment 277421 [details] [review]:

Good, however we'll also need some build infra to make it being installed properly.

::: man/gnome-music.1
@@ +24,3 @@
+Select favorites.
+
+.SH "OPTIONS"

We also accept '-d' and '--debug' options which will display debugging information
Comment 7 Brett 2014-05-30 05:02:59 UTC 
Created attachment 277511 [details] [review]
add man page

I've added the debug options and changed 'only supports standard gnome/gtk options' to 'supports standard gnome/gtk options'.

What is the needed infrastructure that was mentioned? The man/ directory? The patch applied fine for me...
Comment 8 Vadim Rutkovsky 2014-06-23 12:15:21 UTC 
Review of attachment 277511 [details] [review]:

Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=57cc7ed with minor updates