After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707458 - Don't create a dummy texture for the texture pipeline template
Don't create a dummy texture for the texture pipeline template
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-04 12:44 UTC by Neil Roberts
Modified: 2013-09-04 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't create a dummy texture for the texture pipeline template (4.16 KB, patch)
2013-09-04 12:44 UTC, Neil Roberts
committed Details | Review

Description Neil Roberts 2013-09-04 12:44:09 UTC
The meta_create_texture_pipeline function used to create a dummy 1x1
texture so that it could make sure that the all of the state that
affects the shader generation would be set on the template pipeline so
that Cogl could share the pipeline's shader with any other pipelines
that are just rendering a texture. This is no longer necessary because
the only thing that affects the shader generation is the texture type,
not the actual texture data and Cogl now has a function to explicitly
set the texture type which we can use instead. Additionally even if
the template mechanism is not used at all Cogl will still end up
reusing the same shader because it now has a shader cache which is
indexed by the pipeline state so pipeline's don't strictly need to
share ancestry in order to take advantage of it. However we still
might as well use the function because if there is a common ancestry
it is faster to look up the shader because Cogl doesn't need to hash
the pipeline state.
Comment 1 Neil Roberts 2013-09-04 12:44:11 UTC
Created attachment 254064 [details] [review]
Don't create a dummy texture for the texture pipeline template
Comment 2 Florian Müllner 2013-09-04 13:10:25 UTC
Review of attachment 254064 [details] [review]:

OK.
Comment 3 Neil Roberts 2013-09-04 14:30:28 UTC
Ok, thanks. I've pushed it to the master and wayland branches.

https://git.gnome.org/browse/mutter/commit/?id=c5bf60eab427b2b3ec1fbbc7c95d