After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707439 - empty string must not be localized
empty string must not be localized
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: High major
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-04 06:39 UTC by Seán de Búrca
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Don't attempt to translate "" (1.05 KB, patch)
2013-09-04 10:30 UTC, Christophe Fergeau 		committed Details | Review

Description Seán de Búrca 2013-09-04 06:39:26 UTC 
At src/main.vala:15, "" is set to use gettext. This should not be done, as "" has special meaning in gettext and will return information about the locale which should not be necessary for this application to access.
Comment 1 Christophe Fergeau 2013-09-04 10:30:53 UTC 
Created attachment 254051 [details] [review]
main: Don't attempt to translate ""

During the refactoring done in commit  0d6c295, we ended up passing _("")
to g_option context_new(). This is a bad thing to do as "" is a magic
string for gettext. g_option_context_new() can handle NULL, so let's
use that here.
Comment 2 Zeeshan Ali 2013-09-04 14:09:07 UTC 
Review of attachment 254051 [details] [review]:

ack
Comment 3 Christophe Fergeau 2013-09-05 12:08:27 UTC 
Attachment 254051 [details] pushed as f6fcb4d - main: Don't attempt to translate ""