GNOME Bugzilla – Bug 707430
gnome-shell fails to start if bluetooth is not enabled
Last modified: 2013-09-04 10:19:26 UTC
gnome-shell fails to start if bluetooth is not enabled at build-time (HAVE_BLUETOOTH=0 in config.js): Sep 4 00:30:37 localhost gnome-session[3919]: Entering running state Sep 4 00:30:38 localhost gnome-session[3919]: (gnome-settings-daemon:3940): color-plugin-WARNING **: failed to add user icc: Permission non accordée Sep 4 00:30:38 localhost gnome-session[3919]: Avertissement du gestionnaire de fenêtres : Log level 16: Could not load applications usage data: Erreur à l'ouverture du fichi er : Permission non accordée Sep 4 00:30:38 localhost gnome-session[3919]: (gnome-shell:3948): Gjs-WARNING **: JS ERROR: Error: Requiring GnomeBluetoothApplet, version none: Typelib file for namespace ' GnomeBluetoothApplet' (any version) not found Sep 4 00:30:38 localhost gnome-session[3919]: @/usr/share/gnome-shell/js/ui/status/bluetooth.js:5 This seems to occur since commit 5c8c4e0aad4c1e2d05960efdfded7c69225e2d95
Created attachment 254025 [details] [review] panel: fix crash when bluetooth is disabled Attached patch fixes the issue.
Review of attachment 254025 [details] [review]: Thanks for the patch, it's almost correct. ::: js/ui/panel.js @@ +838,3 @@ + this._bluetooth = new imports.ui.status.bluetooth.Indicator(); + this._indicators.add_child(this._bluetooth.indicators); + this.menu.addMenuItem(this._bluetooth.menu); No, you need to keep the relative order with the rest of the menu.
Created attachment 254045 [details] [review] panel: fix crash when bluetooth is disabled Attached is an updated patch keeping ordering. Thanks for your comment
Review of attachment 254045 [details] [review]: You can omit braces if the body of the if/else is one line. Otherwise this is good to commit. Do you have git access?
Aargh, I thought Olivier didn't have git, but he does. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.