After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707362 - gnome-sudoku crashes, code uses old names for gsettings keys
gnome-sudoku crashes, code uses old names for gsettings keys
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal major
: ---
Assigned To: Michael Catanzaro
gnome-sudoku-maint
: 686078 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-03 10:04 UTC by Michael Biebl
Modified: 2014-04-24 15:48 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
[PATCH] Use correct name for always-show-hints GSettings key (1.38 KB, patch)
2013-09-03 10:14 UTC, Michael Biebl 		committed Details | Review

Description Michael Biebl 2013-09-03 10:04:51 UTC 
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=721681

Am 03.09.2013 04:23, schrieb John Foerch:> 
> Gnome-sudoku consistently crashes for me when I press Ctrl-J while
> playing.  Ctrl-J is supposed to be the key to clear top notes.  The
> following error is printed to the terminal:
> 
> (gnome-sudoku:5452): GLib-GIO-ERROR **: Settings schema 'org.gnome.gnome-sudoku' does not contain a key named 'always_show_hints'
> Trace/breakpoint trap
> 

When gnome-sudoku was converted from gconf to gsettings [1], the key was renamed to 'always-show-hints' [2] but the code still uses 'always_show_hints'

I guess the code should be updated to use new name:

src/lib/main.py:        if side == 'Bottom' and self.settings.get_boolean('always_show_hints'):
src/lib/main.py:        if self.settings.get_boolean ('always_show_hints'):


I'm not sure if other keys were renamed too as part of the gsettings conversion, but this should be checked carefully



[1] https://git.gnome.org/browse/gnome-sudoku/commit/?id=3736f8bd6cd77951ecda9403c31155014d60ae19
[2] https://git.gnome.org/browse/gnome-sudoku/tree/data/org.gnome.gnome-sudoku.gschema.xml.in?id=3736f8bd6cd77951ecda9403c31155014d60ae19#n88
Comment 1 Michael Biebl 2013-09-03 10:14:56 UTC 
Created attachment 253944 [details] [review]
[PATCH] Use correct name for always-show-hints GSettings key

When gnome-sudoku was converted from GConf to GSettings all keys were
updated to use '-' instead of '_' but the code wasn't updated
accordingly everywhere.
Comment 2 Michael Biebl 2013-09-03 10:15:55 UTC 
I've added a simple patch to fix this particular issue of always-show-hints vs always_show_hints. I haven't checked all the other keys though.
Comment 3 Matthias Clasen 2013-09-04 21:54:43 UTC 
should probably fix this for 3.10 - crashes are not nice.
Comment 4 Michael Catanzaro 2013-09-05 18:47:32 UTC 
I think this was the only broken key.
Comment 5 Michael Catanzaro 2013-09-05 22:10:03 UTC 
*** Bug 686078 has been marked as a duplicate of this bug. ***