After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707321 - flvdemux: complains too much when failed to send buffers
flvdemux: complains too much when failed to send buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-02 21:28 UTC by Matej Knopp
Modified: 2014-05-19 09:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.76 KB, patch)
2013-09-02 21:28 UTC, Matej Knopp 		needs-work Details | Review

Description Matej Knopp 2013-09-02 21:28:49 UTC 
Created attachment 253906 [details] [review]
Patch

I don't think it should complain about not linked, flushing, etc.
Comment 1 Tim-Philipp Müller 2013-09-02 22:14:53 UTC 
I think this should go like this:

 if (flow != OK) {
    ...
   if (reverse playback eos) {
   } else if (flow == NOT_LINKED) {
     ...
   } else {
     GST_INFO_OR_DEBUG_OBJECT (demux->foo_pad, "got flow %s", gst_flow_get_name (flow)));
   }
 }

FLOW_FLUSHING and FLOW_EOS are both interesting things to log - IMHO it should be quiet on OK and NOT_LINKED but otherwise log something.
Comment 2 Edward Hervey 2014-05-12 11:49:25 UTC 
Whoops, I guess I fixed that without seeing this bug first:

commit 6c4882996f9ad2c2110deb30b7946acd99649006
Author: Edward Hervey <edward@collabora.com>
Date:   Mon May 12 13:46:01 2014 +0200

    flvdemux: Don't use WARNING for not-linked flow return
    
    Pollutes debug logs for no reason. It's only an error if all pads
    return not-linked