GNOME Bugzilla – Bug 707287
Missing high contrast icon
Last modified: 2014-08-29 13:54:44 UTC
As per http://wiki.gnome.org/GnomeGoals/HighContrastAppIcons Will fix up with some graphics for this.
Any news about his? just two modules remaining to close the goal! ;)
(In reply to comment #1) > Any news about his? just two modules remaining to close the goal! ;) Andreas?
Hey! Will try and fix this one tomorrow!
Andreas: ping? ;)
Hey! It would be great to have this for 3.12 release... Any news about it? Thanks!
Created attachment 282080 [details] high contrast icon here you go! sorry that it took a while
Many thanks Andreas! Maintainers: could you please commit it to close this bug? Thanks in advance!
I can push this but since its not a patch :( I'm not sure I know how to include this? Do we just replace the existing svg? What about the png variants?
Adding Mattias Clasen who have been able to help with this in the past.
Here is an example of integrating hc app icons: https://git.gnome.org/browse/baobab/commit/?id=07c459bb096f9e5042acbc9f62d48675970516b2
Created attachment 282541 [details] [review] Adde high contrast icons Thanks Matthias for your guideline to create the patch :)
Review of attachment 282541 [details] [review]: Patch looks good but please follow the project's git log conventions: Add high contrast icons Provide high contrast version of project logo. https://bugzilla.gnome.org/show_bug.cgi?id=707287
No problem from my side, but not sure about how to do it. When using the -m parameter, should I use \n to include a new line in the log? Thanks!
(In reply to comment #13) > No problem from my side, but not sure about how to do it. When using the -m > parameter, should I use \n to include a new line in the log? No, just hitting enter doesn't work? https://wiki.gnome.org/Git/CommitMessages Thanks.
Created attachment 282547 [details] [review] Patch updated Hope now it's ok
(In reply to comment #15) > Created an attachment (id=282547) [details] [review] > Patch updated > > Hope now it's ok Not really. :( Click the 'review' link to see how it turned out to be. I can handle this for you if you like but if you are going to submit patches in future, I thought maybe this would be a good learning experience for you. Up to you!
Just missing blank lines between descriptions lines isn't it? If done it how like you said, but forgot the double intro... will take into account the next time. For not losing more time with this, if you don't mind fix and commit it, i'd be grateful. For the llowing patches now I know hoy to properly format the commit message (thanks for it!)
(In reply to comment #17) > Just missing blank lines between descriptions lines isn't it? That and shortlog has been moved to description and replaced by something that doesn't say anything about patch. > If done it how like you said, but forgot the double intro... will take into > account the next time. You don't need double intro. The first one is shortlog (subject) and rest is description. > For not losing more time with this, if you don't mind fix and commit it, i'd be > grateful. For the llowing patches now I know hoy to properly format the commit > message (thanks for it!) Sure, I'll do that. BTW please do read DISCUSSION in `man git commit` and that link I pasted for future references.
Oh and icon files are missing from second version as well.
Created attachment 282554 [details] [review] Add High Contrast Icons Provide high contrast version of project logo.
Attachment 282554 [details] pushed as ee8a8cb - Add High Contrast Icons
Created attachment 282662 [details] screenshot under GNOME Continuous Hm, this doesn't look quite right :/
(In reply to comment #22) > Created an attachment (id=282662) [details] > screenshot under GNOME Continuous > > Hm, this doesn't look quite right :/ I wondered about that but since I don't have hidpi, I thought I'll just trust you. :) Can you provide new one please?
Created attachment 282701 [details] new icons in all sizes Here are the icons in all sizes, rendered correctly. The gnome-maps-highcontrast.svg should be consithered a "source" file similar to gnome-maps.svg in data/icons and should not be installed.
(In reply to comment #24) > Created an attachment (id=282701) [details] > new icons in all sizes > > Here are the icons in all sizes, rendered correctly. > The gnome-maps-highcontrast.svg should be consithered a "source" file similar > to gnome-maps.svg in data/icons and should not be installed. Non-patch again. :(
Created attachment 284815 [details] [review] patch with the new icons Sorry for not providing a patch earlier. I hope the attached file patch. This stuff is half-magic to me still, so I hope I did it right.
Review of attachment 284815 [details] [review]: I'll fix the commit message but for future reference please try to follow these conventions (they apply to most of gnome projects): https://wiki.gnome.org/Git/CommitMessages
(In reply to comment #27) > Review of attachment 284815 [details] [review]: > > I'll fix the commit message but for future reference please try to follow these > conventions (they apply to most of gnome projects): > https://wiki.gnome.org/Git/CommitMessages oh great, I forgot to update the commit log before pushing. :( Oh well.