After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707269 - NetworkAgent: use g_close() instead of GUnixInputStream
NetworkAgent: use g_close() instead of GUnixInputStream
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-02 08:10 UTC by Giovanni Campagna
Modified: 2013-09-02 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NetworkAgent: use g_close() instead of GUnixInputStream (1.44 KB, patch)
2013-09-02 08:10 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-09-02 08:10:46 UTC 
We created the input stream just to close the FD, but GLib has
a handy close() wrapper, so we can use that instead.
Comment 1 Giovanni Campagna 2013-09-02 08:10:49 UTC 
Created attachment 253809 [details] [review]
NetworkAgent: use g_close() instead of GUnixInputStream
Comment 2 Colin Walters 2013-09-02 16:43:01 UTC 
Review of attachment 253809 [details] [review]:

This one really wants Gio.Subprocess so we can precisely control each stream.  Next cycle...
Comment 3 Giovanni Campagna 2013-09-02 16:45:30 UTC 
Attachment 253809 [details] pushed as a27b44a - NetworkAgent: use g_close() instead of GUnixInputStream