After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707267 - MonitorManager: make sure to pass the right sizes to vararg functions
MonitorManager: make sure to pass the right sizes to vararg functions
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-02 07:34 UTC by Giovanni Campagna
Modified: 2013-09-02 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MonitorManager: make sure to pass the right sizes to vararg functions (2.50 KB, patch)
2013-09-02 07:34 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-09-02 07:34:50 UTC 
A gulong is not enough to get 64 bits in all arches, so we must
cast it, or we can corrupt the stack.

This was downstream bug bugzilla.redhat.com/show_bug.cgi?id=1002055
Comment 1 Giovanni Campagna 2013-09-02 07:34:52 UTC 
Created attachment 253806 [details] [review]
MonitorManager: make sure to pass the right sizes to vararg functions
Comment 2 drago01 2013-09-02 11:29:03 UTC 
Review of attachment 253806 [details] [review]:

OK.
Comment 3 Giovanni Campagna 2013-09-02 13:43:48 UTC 
Attachment 253806 [details] pushed as 46f4ea7 - MonitorManager: make sure to pass the right sizes to vararg functions