After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707199 - [PATCH] Use subdir-objects in Automake init
[PATCH] Use subdir-objects in Automake init
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.10
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-31 22:08 UTC by Kerrick Staley
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use subdir-objects in Automake init (810 bytes, patch)
2013-08-31 22:08 UTC, Kerrick Staley 		committed Details | Review

Description Kerrick Staley 2013-08-31 22:08:29 UTC 
Created attachment 253724 [details] [review]
Use subdir-objects in Automake init

Automake 1.14 prints a warning if subdir-objects is not explicitly specified. gnome-boxes already builds correctly with subdir-objects, so no changes are necessary other than adding subdir-objects to AM_INIT_AUTOMAKE. See [1] for more details.

[1] http://www.gnu.org/software/automake/manual/html_node/List-of-Automake-options.html#index-subdir_002dobjects
Comment 1 Zeeshan Ali 2013-09-02 17:07:34 UTC 
Review of attachment 253724 [details] [review]:

I don't see anything in the pointed docs about this being compulsory but seems harmless and good change anyways. You got commit access?
Comment 2 Kerrick Staley 2013-09-02 18:05:09 UTC 
I don't have commit access; what does it take to get it?

subdir-objects is effectively mandatory because AM_INIT_AUTOMAKE includes the -Wall and -Werror options, meaning the warning causes the build to fail.
Comment 3 Zeeshan Ali 2013-09-02 20:16:45 UTC 
Pushing this on your behalf then. For getting commit acces, you simply need some karma. You collect karma by contributing to some project(s) enough to gain the trust of relevant maintainer(s).

Attachment 253724 [details] pushed as 0a1c319 - Use subdir-objects in Automake init