Created attachment 253708 [details] [review]
datetime: Display notifications on timezone changes

Screenshot: http://kalev.fedorapeople.org/timezone-notification-short-settings.png

Review of attachment 253708 [details] [review]:

::: plugins/datetime/gsd-datetime-manager.c
@@ +102,3 @@
+        /* Translators: UTC here means the Coordinated Universal Time.
+         * %:::z will be replaced by the offset from UTC e.g. UTC+02 */
+        utc_offset = g_date_time_format (datetime, _("UTC%:::z"));

So, this depends on the latest glib.

@@ +131,3 @@
+
+        control_center = g_find_program_in_path ("gnome-control-center");
+        if (control_center != NULL && notification_server_has_actions ()) {

Do you really need to check for the server capabilities here ? won't the actions just be ignored if not supported ?

@@ +141,3 @@
+
+        if (!notify_notification_show (self->priv->notification, NULL)) {
+                g_warning ("failed to send disk space notification\n");

copy-paste error

(In reply to comment #3)
> +        control_center = g_find_program_in_path ("gnome-control-center");
> +        if (control_center != NULL && notification_server_has_actions ()) {
> 
> Do you really need to check for the server capabilities here ? won't the
> actions just be ignored if not supported ?

Not sure, the spec is pretty loosely worded -- I'd be happy to drop the check if you think it's unnecessary and see if anyone complains. I've looked at the g-s-d housekeeping plugin and rhythmbox and both had checks for server capabilities though.

---
Actions	

The actions send a request message back to the notification client when invoked. This functionality may not be implemented by the notification server, conforming clients should check if it is available before using it (see the GetCapabilities message in Protocol). An implementation is free to ignore any requested by the client. As an example one possible rendering of actions would be as buttons in the notification popup.
---

https://developer.gnome.org/notification-spec/

Created attachment 253782 [details] [review]
datetime: Display notifications on timezone changes

Also, bump glib dependency to 2.37.7 for new %z format modifiers.

Attachment 253782 [details] pushed as 37ea000 - datetime: Display notifications on timezone changes