GNOME Bugzilla – Bug 706888
gtype: fix a no-op assertion
Last modified: 2013-08-27 15:01:17 UTC
g_type_class_add_private() was doing g_assert (node->data->instance.private_size <= 0xffff); but that field is a guint16, so the check was a no-op. (Noticed by clang, but not gcc for some reason.) Fix it to do the math in a gssize variable and do the bounds checking there before updating the struct field.
Created attachment 253245 [details] [review] gtype: fix a no-op assertion
Review of attachment 253245 [details] [review]: Looks correct.
Attachment 253245 [details] pushed as 34e1a53 - gtype: fix a no-op assertion