After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706852 - Hide the system actions section in the lock screen
Hide the system actions section in the lock screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-26 23:01 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-08-29 19:17 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
system: Hide the AltSwitcher when we have nothing to show (770 bytes, patch)
2013-08-26 23:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
popupMenu: Make the section invisible if it has no visible children (1.22 KB, patch)
2013-08-26 23:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-08-26 23:01:57 UTC 
Noticed by mclasen.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-08-26 23:01:59 UTC 
Created attachment 253203 [details] [review]
system: Hide the AltSwitcher when we have nothing to show
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-26 23:02:02 UTC 
Created attachment 253204 [details] [review]
popupMenu: Make the section invisible if it has no visible children
Comment 3 Giovanni Campagna 2013-08-28 14:38:28 UTC 
Review of attachment 253203 [details] [review]:

Yes
Comment 4 Giovanni Campagna 2013-08-28 14:39:21 UTC 
Review of attachment 253204 [details] [review]:

This is supposed to be handled by the global separator pass, or not?
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-08-28 14:41:12 UTC 
(In reply to comment #4)
> This is supposed to be handled by the global separator pass, or not?

I don't see where the separator pass checks isEmpty, just visibility. Perhaps it should check isEmpty, but the code there is already not that great.
Comment 6 Ray Strode [halfline] 2013-08-28 14:45:25 UTC 
after this goes in, it may make sense to fix callers that were handling this themselves.  

git grep ection.isEmpty() shows ui/status/keyboard.js but I also see code in ui/status/network.js too that could maybe be modified to leverage this.
Comment 7 Giovanni Campagna 2013-08-28 16:17:27 UTC 
(In reply to comment #5)
> (In reply to comment #4)
> > This is supposed to be handled by the global separator pass, or not?
> 
> I don't see where the separator pass checks isEmpty, just visibility. Perhaps
> it should check isEmpty, but the code there is already not that great.

Yeah, looks fine then.
Comment 8 Matthias Clasen 2013-08-29 19:13:09 UTC 
still not fixed in my ostree-based demo today - wasn't this committed ?
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-08-29 19:17:41 UTC 
Attachment 253203 [details] pushed as f0da08b - system: Hide the AltSwitcher when we have nothing to show
Attachment 253204 [details] pushed as 5a0ac6c - popupMenu: Make the section invisible if it has no visible children