GNOME Bugzilla – Bug 706851
userWidget: Use the user name if the real name doesn't fit
Last modified: 2013-10-30 17:19:49 UTC
This is part of the new designs. See patch.
Created attachment 253201 [details] [review] userWidget: Use the user name if the real name doesn't fit This meets the new designs.
Created attachment 253202 [details] [review] loginDialog: Use UserWidget
Review of attachment 253201 [details] [review]: ::: js/ui/userWidget.js @@ +109,3 @@ + this._currentLabel = this._realNameLabel; + else + this._currentLabel = this._userNameLabel; so this sort of makes the assumption that user name is shorter than real name, which is often true but not always. Also, if they both don't fit, I think it would be better to see an ellipsized real name than an ellipsed user name. @@ +127,3 @@ + if (this._user.is_loaded) { + this._realNameLabel.text = this._user.get_real_name(); + this._userNameLabel.text = this._user.get_user_name(); don't you need to queue a reallocation in thise case?
Review of attachment 253202 [details] [review]: does this make the user list change appearance?
(In reply to comment #3) > so this sort of makes the assumption that user name is shorter than real name, > which is often true but not always. Also, if they both don't fit, I think it > would be better to see an ellipsized real name than an ellipsed user name. I'm not so sure. In some cultures, it's considered rude to truncate the real name, which is why we show the username instead. I think an ellipsized user name is better than an ellipsized real name, but that's an aday question :) > don't you need to queue a reallocation in thise case? The ClutterText/StLabel will queue a relayout for us when the text property changes.