After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706849 - Add a dependency check
Add a dependency check
Status: RESOLVED INVALID
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-26 22:55 UTC by Evgeny Bobkin
Modified: 2013-08-26 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch proposal (1.02 KB, patch)
2013-08-26 22:56 UTC, Evgeny Bobkin 		rejected Details | Review

Description Evgeny Bobkin 2013-08-26 22:55:28 UTC 
gnome-maps does not check for dependencies a build time. There are rumors that you are planning a release, so that should not harm:-)
Comment 1 Evgeny Bobkin 2013-08-26 22:56:40 UTC 
Created attachment 253200 [details] [review]
patch proposal
Comment 2 Zeeshan Ali 2013-08-26 22:57:46 UTC 
Review of attachment 253200 [details] [review]:

We don't have any buildtime deps on these and configure checks are for buildtime only (think cross-compilation).
Comment 3 Zeeshan Ali 2013-08-26 22:58:34 UTC 
Instead we should ensure we list all direct runtime deps in README.
Comment 4 Evgeny Bobkin 2013-08-26 23:06:30 UTC 
(In reply to comment #2)
> Review of attachment 253200 [details] [review]:
> 
> We don't have any buildtime deps on these and configure checks are for
> buildtime only (think cross-compilation).

sure, there is not buildtime deps, but with this patch autotools will warn you if any library is missing and will not let you to proceed.

because as it is, it builds fine and then cause a segmentation fault due to missing deps.

it's up to you, but gnome-weather and other do apply this technique.
Comment 5 Zeeshan Ali 2013-08-26 23:13:49 UTC 
(In reply to comment #4)
> (In reply to comment #2)
> > Review of attachment 253200 [details] [review] [details]:
> > 
> > We don't have any buildtime deps on these and configure checks are for
> > buildtime only (think cross-compilation).
> 
> sure, there is not buildtime deps, but with this patch autotools will warn you
> if any library is missing and will not let you to proceed.

I understand but its wrong to require something at a stage where you don't actually need it.

> because as it is, it builds fine and then cause a segmentation fault due to
> missing deps.

I'll be more than happy to add a runtime deps check in maps.

> it's up to you, but gnome-weather and other do apply this technique.

They are wrong and this "solution" comes at the cost of annoying packagers. I'd welcome a proper solution. Besides this issue wont matter to most people who'll get it from their distro along with all the runtime deps.