After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706777 - background: don't save pixbuf in user data
background: don't save pixbuf in user data
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-26 01:41 UTC by darkxst
Modified: 2013-08-26 16:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: don't save pixbuf in user data (1.26 KB, patch)
2013-08-26 01:42 UTC, darkxst 		committed Details | Review

Description darkxst 2013-08-26 01:41:59 UTC 
This is causing around 30MB of memory usage on my system. Do we need to keep these pixbuf
in memory?
Comment 1 darkxst 2013-08-26 01:42:01 UTC 
Created attachment 253089 [details] [review]
background: don't save pixbuf in user data
Comment 2 Ray Strode [halfline] 2013-08-26 15:23:19 UTC 
Review of attachment 253089 [details] [review]:

I think is right.  I originally cribbed the user data thing from cogl_bitmap_new_for_data here:  https://git.gnome.org/browse/cogl/tree/cogl/cogl-bitmap-pixbuf.c#n247  but we're a different case here since the texture data is going to be uploaded right away.  cogl_texutre_new_from_data free's it's cogl bitmap after doing the upload.
Comment 3 Ray Strode [halfline] 2013-08-26 15:24:42 UTC 
(also see Bug 696157 Comment 22 where I incorrectly asserted it was necessary)
Comment 4 drago01 2013-08-26 16:26:20 UTC 
Attachment 253089 [details] pushed as e74ed92 - background: don't save pixbuf in user data