After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706767 - Remove markup from translatable strings
Remove markup from translatable strings
Status: RESOLVED DUPLICATE of bug 670650
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: Git
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 682886
 
 
Reported: 2013-08-25 20:47 UTC by Aurimas Černius
Modified: 2013-09-12 17:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for found strings (2.14 KB, patch)
2013-08-25 20:47 UTC, Aurimas Černius 		needs-work Details | Review
Fix for found strings (2.15 KB, patch)
2013-09-08 16:26 UTC, Aurimas Černius 		none Details | Review

Description Aurimas Černius 2013-08-25 20:47:20 UTC 
Created attachment 253075 [details] [review]
Fix for found strings

Translatable strings if possible should not contain markup.
The attached patch removes two of them I found while translating.
WARNING: I haven't tried to run app with these changes!
Comment 1 Jean-François Fortin Tam 2013-09-01 03:07:26 UTC 
Review of attachment 253075 [details] [review]:

Hi and thanks for this!
There is a problem however... whenever you open those files with glade and save, Glade will override your values like this:

-                  <attribute name="size" value="larger"/>
+                  <attribute name="size" value="0"/>

...but then the text is not visible anymore.

Even then however, it seems that Glade was at least trying to do the correct thing... because if I try your patch vanilla (with value="larger"), I get this traceback when rendering:

Traceback (most recent call last):

+ Trace 232441

  • File "~/pitivi-git/pitivi/pitivi/render.py", line 860 in _renderButtonClickedCb 
    self.progress = RenderingProgressDialog(self.app, self)
  • File "~/pitivi-git/pitivi/pitivi/render.py", line 241 in __init__ 
    "renderingprogress.ui"))
  • File "~/pitivi-git/pygobject/gi/types.py", line 113 in function 
    return info.invoke(*args, **kwargs)
gi._glib.GError: Could not parse integer `larger' 






Comment 2


Aurimas Černius





          2013-09-08 16:26:49 UTC
        



Created attachment 254421 [details] [review]
Fix for found strings

Looks like it should be "font_size" instead of "size". At least Glade now shows these two labels.






Comment 3


Jean-François Fortin Tam





          2013-09-10 01:51:47 UTC
        



Hi Aurimas,
The problem remains: glade will ignore and reset those properties. Try saving the glade file and you'll notice those attributes you added are now gone... I'm wondering if that's now an actual bug in glade that needs to be filed as a dependency for this bug here.

(note: you should update your git checkout of master as one of the strings has been replaced by something else :)






Comment 4


Jean-François Fortin Tam





          2013-09-12 17:14:11 UTC
        



Actually, this is the same issue as 670650 so let's continue there.

*** This bug has been marked as a duplicate of bug 670650 ***