After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706706 - Fix Gir annotations on g_loadable_icon_load_finish
Fix Gir annotations on g_loadable_icon_load_finish
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-08-24 11:32 UTC by Jonas Danielsson
Modified: 2013-08-25 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix gir bindings for load finish (1.02 KB, patch)
2013-08-24 11:35 UTC, Jonas Danielsson 		committed Details | Review

Description Jonas Danielsson 2013-08-24 11:32:36 UTC 
The Gir annotations for load_finish() differ from the ones in load() in regards to how the type parameter is annotated. This makes it difficult to use load_finish in for instance gjs (maps).

Patch below.

Thanks.
Comment 1 Jonas Danielsson 2013-08-24 11:35:05 UTC 
Created attachment 253007 [details] [review]
Fix gir bindings for load finish
Comment 2 Colin Walters 2013-08-24 12:53:07 UTC 
Review of attachment 253007 [details] [review]:

Looks good, thank you!
Comment 3 Jonas Danielsson 2013-08-24 13:28:04 UTC 
Thanks! When can one expect it to land in gobject-introspection?
Comment 4 Colin Walters 2013-08-25 13:01:49 UTC 
(In reply to comment #3)
> Thanks! When can one expect it to land in gobject-introspection?

Just now: https://git.gnome.org/browse/gobject-introspection/commit/?id=c2bc74b5e8d7c22bf675a334adafa44c0740af9f

Will be in the 1.38.0 release.