After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706673 - Toolbar has a double bottom border
Toolbar has a double bottom border
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Main Toolbar
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 706710 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-08-23 15:30 UTC by Allan Day
Modified: 2013-08-24 15:16 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
nautilus: Remove duplicate borders (1.54 KB, patch)
2013-08-23 18:23 UTC, António Fernandes 		committed Details | Review
nautilus: Remove search bar top border, add bottom border (1.41 KB, patch)
2013-08-23 20:09 UTC, António Fernandes 		none Details | Review
nautilus: Drop search bar overrides for tabs (1.18 KB, patch)
2013-08-23 20:10 UTC, António Fernandes 		none Details | Review
nautilus: Remove search bar top border, add bottom border (1.34 KB, patch)
2013-08-23 20:45 UTC, António Fernandes 		committed Details | Review
nautilus: Drop search bar overrides for tabs (1.13 KB, patch)
2013-08-23 20:49 UTC, António Fernandes 		committed Details | Review

Description Allan Day 2013-08-23 15:30:15 UTC 
The bottom border is 2px wide. It should be 1px.

Could be due to bug 706418 being fixed.
Comment 1 António Fernandes 2013-08-23 18:23:48 UTC 
Created attachment 252940 [details] [review]
nautilus: Remove duplicate borders

The toolbar has a bottom border now, which, added to the top borders on the places sidebar, the pane separator, and the notebook frame, results in a double border. Remove the later three to get a single border.

This is a patch for gnome-themes-standard.
Comment 2 António Fernandes 2013-08-23 20:09:52 UTC 
Created attachment 252946 [details] [review]
nautilus: Remove search bar top border, add bottom border

The search bar theming was expecting a border below and no border above. Now that the toolbar is drawing the border, we need to draw a bottom border instead of a top border.
Comment 3 António Fernandes 2013-08-23 20:10:34 UTC 
Created attachment 252947 [details] [review]
nautilus: Drop search bar overrides for tabs

The theming of the search bar for "no tabs" is identical now.
Comment 4 António Fernandes 2013-08-23 20:45:50 UTC 
Created attachment 252950 [details] [review]
nautilus: Remove search bar top border, add bottom border

The search bar theming was expecting a border below and no border above. Now that the toolbar is drawing the border, we need to draw a bottom border instead of a top border.

Changed from first version of the patch: Remove bottom border if search bar is not the only child of the query editor.
Comment 5 António Fernandes 2013-08-23 20:49:52 UTC 
Created attachment 252951 [details] [review]
nautilus: Drop search bar overrides for tabs

The theming of the search bar for "no tabs" is identical now.
Comment 6 António Fernandes 2013-08-24 13:27:39 UTC 
*** Bug 706710 has been marked as a duplicate of this bug. ***
Comment 7 Cosimo Cecchi 2013-08-24 15:16:13 UTC 
Thanks Antonio! I pushed all of these, with an additional cleanup patch, to git master now.

Attachment 252940 [details] pushed as c7d2778 - nautilus: Remove duplicate borders
Attachment 252950 [details] pushed as 823af26 - nautilus: Remove search bar top border, add bottom border
Attachment 252951 [details] pushed as fe21bba - nautilus: Drop search bar overrides for tabs