After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706661 - Able to add duplicate folders in media sharing
Able to add duplicate folders in media sharing
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-23 13:25 UTC by celine.LEGUAY
Modified: 2013-10-02 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sharing: prevent duplicate folders being selected for media sharing (1.71 KB, patch)
2013-10-02 14:53 UTC, Thomas Wood 		committed Details | Review

Description celine.LEGUAY 2013-08-23 13:25:55 UTC 
the version is gnome-user-share-3.8.0-1.fc19.x86_64

User can notice that they can add the duplicate folders again in media sharing.
Steps :
1. Boot 
2. Open Settings - sharing - media sharing
3. Click "+" button
4. Add Music
5. Observe duplicate folders
Expected outcome
Cannot re-add the same folder
Actual outcome
Can re-add same folder to have duplicate
Comment 1 Thomas Wood 2013-10-02 14:53:13 UTC 
Created attachment 256284 [details] [review]
sharing: prevent duplicate folders being selected for media sharing
Comment 2 Bastien Nocera 2013-10-02 15:28:51 UTC 
Review of attachment 256284 [details] [review]:

The rest looks fine.

::: panels/sharing/cc-sharing-panel.c
@@ -436,2 @@
   g_free (folder);
-

Whitespace change here.
Comment 3 Thomas Wood 2013-10-02 15:44:41 UTC 
Attachment 256284 [details] pushed as fa44b21 - sharing: prevent duplicate folders being selected for media sharing