After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706659 - HLink tooltips are not hidden on sheet change
HLink tooltips are not hidden on sheet change
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-08-23 13:09 UTC by Michael Uplawski
Modified: 2014-03-25 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Project in evolution: a database of my vegetable seeds. (9.95 KB, application/x-gnumeric)
2013-08-23 13:09 UTC, Michael Uplawski
Details
Hello, my name is BUG (103.65 KB, image/png)
2014-03-24 19:54 UTC, Steff
Details

Description Michael Uplawski 2013-08-23 13:09:31 UTC
Created attachment 252846 [details]
Project in evolution: a database of my vegetable seeds.

Gnumeric 1.12.4
Ubuntu Linux 13.04
Fluxbox/Rox

Good afternoon

In a workbook of several tables, some content is linked internally
across table-borders.

The tool-tips which appear when hovering over such a link do not always
disappear as expected when I move the mouse away from the link. While it
is not a safe method to reproduce the phenomenon, it appears to happen
mostly, when I also click on the link, while the tool-tip is at display.

This way you can keep several tool-tips open at the same time and even
keep them visible when you focus a different application-window. I had
to close Gnumeric to write this mail, because the tool-tips clutter the
window.  The screen-shots:

http://pix.toile-libre.org/?img=1377202658.png
http://pix.toile-libre.org/?img=1377202710.png

And because I am once not under constraint of privacy, I even attach the
affected file to this mail. A spreadsheet program may not be the right
application for this kind of work, but I had different things in mind
when I started the document. Anyway, there is a problem with the tool-tips.

Cheerio,
Comment 1 Andreas J. Guelzow 2013-08-23 17:04:54 UTC
I can replicate this. Note that we are dealing with internal links here so clicking on them moves the selection to a different part of the sheet without removing the tool tip. I do not seem to get more than 2 tool tips though.
Comment 2 Michael Uplawski 2013-08-23 17:21:59 UTC
(In reply to comment #1)
> I do not seem to get more than 2 tool tips though.

You may be right. I can see a third one temporarily when hovering over another link, but one usually disappears shortly after. I cannot say though that I know in advance, which one is doomed. Having not set a tooltip-text myself, those three lines of text per tooltip are sufficient to unnerve me.
Comment 3 Michael Uplawski 2013-08-23 17:36:23 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > I do not seem to get more than 2 tool tips though.

And no. I was too quick. An arbitrary number of tool-tips may be difficult to produce, but see, how I access this bugzilla... :-(

http://pix.toile-libre.org/?img=1377279364.png
Comment 4 Andreas J. Guelzow 2013-08-23 18:13:24 UTC
I think I see what is going on:

The first tooltip is attached to the itemgrid of one sheet.
Clicking on a link switches to another sheet without deleting the tooltip.
The second sheet has a different itemgrid. So we can get a new tooltip there.
if we ever return to a sheet with a tooltip already showing, that tooltip will disappear.
Comment 5 Andreas J. Guelzow 2013-08-23 18:23:02 UTC
I would have expected item_grid_leave_notify to be triggered on a sheet change but it only seems to be triggered when a sheet is deleted.

In item_grid_leave_notify we delete any existing tooltip. We need to figure out how to ensure that item_grid_leave_notify is triggered on a sheet change.

As a separate note: item_grid_leave_notify calls ig_clear_hlink_tip which sets ig->cursor_timer to 0, why are we doing that again in item_grid_leave_notify?
Comment 6 Jean Bréfort 2014-03-02 19:15:17 UTC
This one is now fixed. Feel free to reopen if the problem persists with latest gnumeric.This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 7 Steff 2014-03-07 15:18:22 UTC
It seems this is not fully fixed even in version 1.12.12.

To reproduce:
Make first a hyperlink with a tooltip.
Then open for example the gnumeric internal search window.
Hover over the hyperlink to show the tooltip.
Then switch to another application with Alt + Tab.
The hyperlink tooltip should stay open.
Comment 8 Jean Bréfort 2014-03-07 15:22:30 UTC
Hmm, I see, but no idea at the moment about how to fix that.
Comment 9 Jean Bréfort 2014-03-15 10:39:00 UTC
The previous fix was wrong. We need to use the leave_notify event (I thought we used it, but it was not actually the case). The issue is that we must also move toe tip to a slightly different position to avoid such an event when displaying the tip or it will be destroyed just after its creation end hence never visible.
Comment 10 Jean Bréfort 2014-03-15 10:53:36 UTC
Really fixed now.
Comment 11 Michael Uplawski 2014-03-17 16:59:57 UTC
As you write about “moving the toe tip” around... (nice), have you considered, that a tooltip may be invisible because the link that I am hovering above, is located quite low on the screen and the tooltip disappears completely, probably because it fell out from below... 8-) Ah, I see what you mean now. Need to move my toe tips, else they are hit by a tool-tip.

Cheerio.
Comment 12 Steff 2014-03-24 19:54:05 UTC
Created attachment 272813 [details]
Hello, my name is BUG
Comment 13 Michael Uplawski 2014-03-25 07:43:55 UTC
Cannot reproduce the error from my last comment 11, above, nor that of Steff in comment 12 in Gnumeric 1.1.13 from the Debian repositories.
Comment 14 Michael Uplawski 2014-03-25 07:44:43 UTC
1.12.13, typo in comment 13
Comment 15 Jean Bréfort 2014-03-25 08:51:25 UTC
Steff, which version?
Comment 16 Steff 2014-03-25 09:31:51 UTC
> Steff, which version?

I build from source yesterday.

I found out that this patch is missing in newest gnumeric source:

https://bugzilla.gnome.org/attachment.cgi?id=269312

After adding the line "	g_signal_connect_swapped (item->canvas, "state-flags-changed", G_CALLBACK (ig_clear_hlink_tip), item);" the bug is gone.
Comment 17 Jean Bréfort 2014-03-25 09:37:52 UTC
I believed that this patch was not anymore needed. How do you fire this bug?
Comment 18 Steff 2014-03-25 09:49:47 UTC
You need to make a internal link with a tooltip, and the link has to lead to a different sheet than the current.