nautilus needs to return the right value from its event handler to indicate that the event has been fully handled, not let it bubble up.

Created attachment 252870 [details] [review]
pathbar: do not bubble up button-press-event

Comment on attachment 252870 [details] [review]
pathbar: do not bubble up button-press-event

obviously this was too simple :)

Created attachment 252881 [details] [review]
pathbar: do not unconditionally bubble up button-press-event

Review of attachment 252881 [details] [review]:

looks fine to me

Thanks! Pushed this, and another patch on top of it, that uses a return value from path-event instead of depending on the window and the pathbar being in sync on the knowkledge of what happened.

Attachment 252881 [details] pushed as 0f30343 - pathbar: do not unconditionally bubble up button-press-event

I just noticed that there are other events that should be filtered in path_bar_path_event_callback as well:
- middle click sends the window to the background
- double clicking maximizes the window

But adding all those exceptions feels a bit wrong to me and would break whenever new events get added to the header bar. Maybe it would make more sense to default to TRUE in path_bar_path_event_callback and only return FALSE on events that would be handled by the buttons in the path bar. That way everything would be contained in the nautilus source and it would not depend on gtk not adding new events to the header bar.

Created attachment 253054 [details] [review]
window: Handle middle click in pathbar event callback

Probabily this is needed, too

*** Bug 706765 has been marked as a duplicate of this bug. ***

Review of attachment 253054 [details] [review]:

Looks good for now.

Comment on attachment 253054 [details] [review]
window: Handle middle click in pathbar event callback

Attachment 253054 [details] pushed as 9b6abc6 - window: Handle middle click in pathbar event callback

*** Bug 707583 has been marked as a duplicate of this bug. ***