After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706592 - csd: some fixes for the titlebar
csd: some fixes for the titlebar
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 706418
 
 
Reported: 2013-08-22 15:23 UTC by Cosimo Cecchi
Modified: 2013-08-24 00:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: don't change bottom margin for automatic CSD (1.01 KB, patch)
2013-08-22 15:23 UTC, Cosimo Cecchi 		committed Details | Review
window: add a style class when we automatically create the titlebar (950 bytes, patch)
2013-08-22 15:23 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-08-22 15:23:04 UTC 
These are needed to properly solve bug 706418.
Comment 1 Cosimo Cecchi 2013-08-22 15:23:06 UTC 
Created attachment 252766 [details] [review]
window: don't change bottom margin for automatic CSD

We'll use a style class to be able to give this a different appearance,
but for the time being we don't really need to give this such different
margin.
Comment 2 Cosimo Cecchi 2013-08-22 15:23:10 UTC 
Created attachment 252767 [details] [review]
window: add a style class when we automatically create the titlebar

To distinguish it from custom titlebars added from applications.
Comment 3 Matthias Clasen 2013-08-23 00:15:23 UTC 
Review of attachment 252766 [details] [review]:

sure
Comment 4 Matthias Clasen 2013-08-23 00:17:23 UTC 
Review of attachment 252767 [details] [review]:

Why is it important to distinguish them ? titlebar is titlebar, no ?
Comment 5 Cosimo Cecchi 2013-08-23 08:11:48 UTC 
Because, as the automatic decoration is implemented with a header bar as well, if we don't special case it, it will get the bottom border typical of headers, which we don't generally want for the automatic case.
Comment 6 Matthias Clasen 2013-08-23 14:00:13 UTC 
Review of attachment 252767 [details] [review]:

ok then
Comment 7 Matthias Clasen 2013-08-24 00:17:37 UTC 
Attachment 252766 [details] pushed as fde3d5a - window: don't change bottom margin for automatic CSD
Attachment 252767 [details] pushed as 6928aed - window: add a style class when we automatically create the titlebar