After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706536 - Fixes for hovering over tray icons
Fixes for hovering over tray icons
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-21 20:50 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-08-21 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-shell-plugin: Remove old code to detect crossing events (2.87 KB, patch)
2013-08-21 20:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
shell-gtk-embed: Make the MetaWindowActor for a tray icon unreactive (1.10 KB, patch)
2013-08-21 20:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-08-21 20:50:25 UTC 
It turns out the issues with the :hover state going away when
hovering is not what we thought! This is a regression from
bpeel's tray icon work.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-08-21 20:50:27 UTC 
Created attachment 252672 [details] [review]
gnome-shell-plugin: Remove old code to detect crossing events

Ever since we stopped reparenting status icon windows to the stage, tray icons
haven't been inferiors and thus we don't have to filter out enter/leave events
for them, as we never show them outside of a modal.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-21 20:50:31 UTC 
Created attachment 252673 [details] [review]
shell-gtk-embed: Make the MetaWindowActor for a tray icon unreactive

The MetaWindowActor isn't painted, and we empty its input shape in
the X scene graph, but Clutter still picked it. Set it as unreactive
so that it can't be picked.
Comment 3 Giovanni Campagna 2013-08-21 20:53:24 UTC 
Review of attachment 252672 [details] [review]:

Yes.
Comment 4 Giovanni Campagna 2013-08-21 20:57:37 UTC 
Review of attachment 252673 [details] [review]:

We need to clean up this code at some point, but ok for now.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-08-21 20:59:23 UTC 
Attachment 252672 [details] pushed as 8581e98 - gnome-shell-plugin: Remove old code to detect crossing events
Attachment 252673 [details] pushed as ae80e81 - shell-gtk-embed: Make the MetaWindowActor for a tray icon unreactive