After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706495 - core: Use g_clear_error()/g_clear_object()/g_list_free_full()
core: Use g_clear_error()/g_clear_object()/g_list_free_full()
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-21 13:07 UTC by Emanuele Aina
Modified: 2013-08-23 23:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: Use g_clear_error()/g_clear_object()/g_list_free_full() (6.39 KB, patch)
2013-08-21 13:07 UTC, Emanuele Aina
committed Details | Review

Description Emanuele Aina 2013-08-21 13:07:27 UTC
Simplify cleanup functions by relying on the NULL-safe versions of
g_error_free()/g_object_unref() and free lists and their elements in a
single pass.
Comment 1 Emanuele Aina 2013-08-21 13:07:29 UTC
Created attachment 252550 [details] [review]
core: Use g_clear_error()/g_clear_object()/g_list_free_full()

Simplify cleanup functions by relying on the NULL-safe versions of
g_error_free()/g_object_unref() and free lists and their elements in a
single pass.
Comment 2 Juan A. Suarez Romero 2013-08-23 23:20:35 UTC
Attachment 252550 [details] pushed as c53c9c4 - core: Use g_clear_error()/g_clear_object()/g_list_free_full()

commit c53c9c4b8ae706d6a0096873ced8c076fcdf97b4
Author: Emanuele Aina <emanuele.aina@collabora.com>
Date:   Wed Aug 21 15:04:14 2013 +0200

    core: Use g_clear_error()/g_clear_object()/g_list_free_full()
    
    Simplify cleanup functions by relying on the NULL-safe versions of
    g_error_free()/g_object_unref() and free lists and their elements in a
    single pass.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706495

 src/grl-multiple.c          |  5 +----
 src/grl-operation-options.c |  3 +--
 src/grl-source.c            | 52 +++++++++++++++-------------------------------------
 3 files changed, 17 insertions(+), 43 deletions(-)