GNOME Bugzilla – Bug 706446
Pushed button text isn't very legible
Last modified: 2013-08-20 23:39:09 UTC
Right now the text on pushed buttons is white with regular weight. In the dark theme, it is blue with regular weight. This is hard to read in the light theme. In the dark theme it is a bit blingy. It doesn't follow the mockups in either case: https://raw.github.com/gnome-design-team/gnome-mockups/master/theming/widgets/widget-factory.png In addition, the path bar seems to be inconsistent, in that it uses bold text weight for pushed buttons.
Created attachment 252479 [details] [review] patch The attached patch is the best I could do. It has a few problems though: 1. The change to the dark theme doesn't seem to apply for some reason. 2. I couldn't figure out how to get rid of the bold weight for the path bar.
Review of attachment 252479 [details] [review]: ::: themes/Adwaita/gtk-3.0/gtk-main-dark.css @@ +45,3 @@ @define-color button_active_gradient_color_a shade (@button_gradient_color_b, 0.7); @define-color button_active_gradient_color_b shade (@button_gradient_color_a, 0.7); +@define-color button_active_text @theme_text_color; There's probably another override in gtk-widgets-dark-overrides.css that changes that color again to @theme_selected_bg_color for the dark theme.
As for your second issue, I think the label in the pathbar is made bold from code. If we want it to be of regular weight instead, we should patch nautilus and GtkFileChooser.
Created attachment 252483 [details] [review] updated patch Thanks for the hint, Cosimo. I found the override I needed to override. I'm not exactly clear about why the override is needed, it should be added, and am not sure about what changing it will do. It would be great to look at changing the pathbar to match Adwaita. It sucks that the style is defined in the code.
(In reply to comment #4) > Thanks for the hint, Cosimo. I found the override I needed to override. I'm not > exactly clear about why the override is needed, it should be added, and am not > sure about what changing it will do. Honestly I don't remember why that was needed - but it's definitely not needed if we make it use the same color as the non-pushed state, so I would just remove that line from the selector (the shadow overrides are still needed). > It would be great to look at changing the pathbar to match Adwaita. It sucks > that the style is defined in the code. I agree - I will take a look at changing that for nautilus and the file chooser. In the meantime, feel free to push your patch with that useless override removed.
Pushed the updated patch: https://git.gnome.org/browse/gnome-themes-standard/commit/?id=697a4fea200e2605a95cef9d0d9979fe0073cd0f Thanks Cosimo!
Filed bug 706451 for the path bar issue.