After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706442 - printer: allow building against cups 1.5
printer: allow building against cups 1.5
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: printers
unspecified
Other All
: Normal normal
: ---
Assigned To: Marek Kašík
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-20 20:24 UTC by Dominique Leuenberger
Modified: 2013-08-28 19:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printer: allow building against cups 1.5 (1.27 KB, patch)
2013-08-20 20:24 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2013-08-20 20:24:52 UTC 
CUPS 1.6 introduced various getters/setters, which are missing in CUPS 1.5.

Code blocks in the patch copied from gnome-control-center.
Comment 1 Dominique Leuenberger 2013-08-20 20:24:54 UTC 
Created attachment 252473 [details] [review]
printer: allow building against cups 1.5
Comment 2 Matthias Clasen 2013-08-20 21:49:57 UTC 
Review of attachment 252473 [details] [review]:

looks fine to me
Comment 3 Matthias Clasen 2013-08-20 21:50:34 UTC 
Review of attachment 252473 [details] [review]:

looks fine to me
Comment 4 Dominique Leuenberger 2013-08-25 19:34:28 UTC 
(In reply to comment #3)
> Review of attachment 252473 [details] [review]:
> 
> looks fine to me

Does that mean I should push?
Comment 5 Marek Kašík 2013-08-26 09:21:32 UTC 
Comment on attachment 252473 [details] [review]
printer: allow building against cups 1.5

Hi Dominique,

thank you for catching this. Push it to master please.

Thanks

Marek
Comment 6 Dominique Leuenberger 2013-08-28 19:27:26 UTC 
Attachment 252473 [details] pushed as 8c67d07 - printer: allow building against cups 1.5