GNOME Bugzilla – Bug 706418
HeaderBars don't have a bottom border
Last modified: 2013-08-23 11:51:25 UTC
Created attachment 252448 [details] one example of many A lot of apps have been ported to use HeaderBars for 3.10. None of them have a visible bottom border though.
Seems that reverting this commit fixes the issue: https://git.gnome.org/browse/gnome-themes-standard/commit/?id=7283721c8cfe19ab9a26288758ecf364a56f01fe
Seems like the commit was done to remove bottom borders on titlebars under CSD.
Maybe we should add the border only on GtkHeaderBar.titlebar and not on all .titlebars
Created attachment 252768 [details] [review] csd: don't override border and box shadow for titlebars Since .titlebar is added by default to all the widgets used as titles for a toplevel, we can't override the border image or the box shadow as, for instance, headerbars want to render those. A following commit will remove the borders explicitly in case the client side decoration is the default one added automatically by GTK.
Created attachment 252769 [details] [review] csd: don't draw a border for automatic CSD titles added by GTK For those we want to be consistent with the mutter theme we have nowadays, so use the extra style class to distinguish that case, and remove any border there.
Works for me in the HeaderBar case. Have been unable to test for CSD and titlebar though.
Attachment 252768 [details] pushed as 7acd518 - csd: don't override border and box shadow for titlebars Attachment 252769 [details] pushed as 99f550f - csd: don't draw a border for automatic CSD titles added by GTK