After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706323 - HeaderBar window menus
HeaderBar window menus
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
3.10
Depends on:
Blocks:
 
 
Reported: 2013-08-19 15:55 UTC by Allan Day
Modified: 2013-09-17 19:39 UTC
See Also:
GNOME target: 3.10
GNOME version: 3.9/3.10


Attachments
gtk/gtkwindow.c: Fix on non-X11 (1.16 KB, patch)
2013-08-26 04:14 UTC, Fan, Chun-wei
committed Details | Review

Description Allan Day 2013-08-19 15:55:03 UTC
HeaderBars have a simple window menu with Minimize, Maximize and Close. They should be identical to the standard window menus you get with a titlebar.
Comment 1 Matthias Clasen 2013-08-19 17:23:23 UTC
Some of those actions may not easily doable client-side.

Move - gdk_window_begin_move_drag
Resize - gdk_window_begin_resize_drag
Always on Top - gtk_window_set_keep_above
Always on Visible Workspace - gtk_window_stick
Only on this Workspace - gtk_window_unstick
Move to Workspace Up - missing api
Move to Workspace Down - missing api
Move to Workspace n - missing api
Comment 2 Allan Day 2013-08-19 17:34:51 UTC
(In reply to comment #1)
> Some of those actions may not easily doable client-side.
...

Hmm, OK. Well let's see. I'm not too concerned about move and resize; any of the others would be nice to have.
Comment 3 Matthias Clasen 2013-08-20 12:32:55 UTC
There's also a few new ones we should consider:

Move to monitor left/right/up/down
Move to presentation screen
Comment 4 Matthias Clasen 2013-08-20 12:54:18 UTC
The complication with all of these is that they have state that we need to get to the client-side: am I on the last/first workspace ? is there a monitor to the right ? is there a presentation display ?
Comment 5 Elad Alfassa 2013-08-23 09:07:41 UTC
Since we are already too close to 3.10 to make all those new APIs, perhaps we should add the options that we can, and postpone the rest to the next cycle? Always On Top is a very useful feature and it would be unfortunate if it disappears for a whole cycle...
Comment 6 Matthias Clasen 2013-08-23 13:58:50 UTC
these apis are internal between gdk and gtk. I wouldn't hesitate to add them
Comment 7 Matthias Clasen 2013-08-24 04:54:09 UTC
I've now implemented all except for move and resize. Curiously, these turn out to be the harder, since the apis we have don't quite seem to work here.
Comment 8 Matthias Clasen 2013-08-24 04:59:12 UTC
oh, and none of this works on wayland - we don't have always-on-top, or sticky, or workspaces implemented there.
Comment 9 drago01 2013-08-25 18:09:59 UTC
(In reply to comment #8)
> oh, and none of this works on wayland - we don't have always-on-top, or sticky,
> or workspaces implemented there.

Do we have bugs filed for those?
Comment 10 Matthew Miller 2013-08-25 21:18:29 UTC
Another RFE for tradition functionality that's missing: double-click (or click an optional UI element) to Toggle Shade.

I know this isn’t a UI priority, but it has been available via the Tweak Tool, and I find it a really handy way to work with the need to get windows temporarily out of the way instead of minimizing. With window shade, the spacial identity of a window is retained. (And so it plays nicely with the overview mode, which is awesome.)
Comment 11 Fan, Chun-wei 2013-08-26 04:14:35 UTC
Created attachment 253090 [details] [review]
gtk/gtkwindow.c: Fix on non-X11

Hi,

I'm sorry to say this, but the patch 7e4bcf91 ("Add workspace handling to the window menu") would break the build of gtk/gtkwindow.c on non-X11 platforms.  I have here a simple patch to address this.

With blessings, thank you!
Comment 12 Fan, Chun-wei 2013-08-26 04:24:44 UTC
Sorry, the commit should be 7e4bcf91.  Sorry for the noise.
Comment 13 Matthias Clasen 2013-08-26 12:20:21 UTC
Review of attachment 253090 [details] [review]:

oh, sorry about that
Comment 14 Fan, Chun-wei 2013-08-26 13:35:32 UTC
Review of attachment 253090 [details] [review]:

Hi,

Thanks.  The patch (attachment 253090 [details] [review]) was pushed as c8cad491.

With blessings.
Comment 15 Matthias Clasen 2013-08-26 22:33:30 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > oh, and none of this works on wayland - we don't have always-on-top, or sticky,
> > or workspaces implemented there.
> 
> Do we have bugs filed for those?

No, we don't. Implementing these will require defining/extending a xdg_shell interface to replace the basic wl_shell one.
Comment 16 Matthias Clasen 2013-08-26 22:34:08 UTC
I'll consider this bug done for now.