GNOME Bugzilla – Bug 706285
Add webp image format support
Last modified: 2013-12-23 14:16:56 UTC
I have some WIP stuffs on webpimage format support in my personal repository. Only added the decoder at the moment. https://github.com/sreerenjb/gst-webp
Are you planning to submit patches against gst-plugins-bad?
I was thinking to add encoder+muxer and then a patch against plugins-bad but too busy with other stuffs now :( . So if anyone interested then it is always welcome to add the encoder+muxer to this or I will do it later(once i get time).
Ok, so what's the point of this bug report then? :)
"Just wanted to update that a gstreamer element for webp decoding is available and please don't duplicate the decoder work " Is that an enough explanation for creating a bug for this ? :)
Yeah, but without any concrete plans to merge it this is rather useless nonetheless :) Maybe try to provide a patch that merges that decoder element only into -bad and then we can get rid of this bug report, and later encoder and other things can be added. What kind of muxer/demuxer is necessary here btw?
(In reply to comment #5) > Yeah, but without any concrete plans to merge it this is rather useless > nonetheless :) Maybe try to provide a patch that merges that decoder element > only into -bad and then we can get rid of this bug report, and later encoder > and other things can be added. > > What kind of muxer/demuxer is necessary here btw? Yup. Make sense :) I will provide a patch to gst-plugins-bad/ext with only the decoder later this week. Is that okay? WebP has an experimental api to add metas to webp image. https://developers.google.com/speed/webp/docs/riff_container?csw=1
RIFF *shudder* Is webp valid without the RIFF header? If possible I would put this all into the encoder and decoder instead, it doesn't seem worth additional elements.
No. WebP should always start with a RIFF header :). Ya, it could be possible to put all stuffs into ecoder/decoder i guess. But for now i can provide only the decoder in my repository. Is that okay?
of course :)
Created attachment 252984 [details] [review] Add WebP image decoder plugin
Created attachment 252985 [details] [review] webpdec: Add PTS using framerate based interpolation.
Review of attachment 252985 [details] [review]: ::: ext/webp/gstwebpdec.c @@ +467,3 @@ + duration = gst_webp_dec_get_frame_duration (webpdec); + if (GST_CLOCK_TIME_IS_VALID (duration)) { + webpdec->pts += duration; You accumulate rounding errors here, count the frames and calculate nframes / fps.
Comment on attachment 252984 [details] [review] Add WebP image decoder plugin commit f7db01b0e17b3831796c7d70f49af5214d46b1c7 Author: Sebastian Dröge <slomo@circular-chaos.org> Date: Mon Aug 26 10:22:06 2013 +0200 webpdec: Some cleanup and minor fixes commit 499d515a9f7211d61155ff312023d00cf93c0c40 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Sat Aug 24 00:46:38 2013 +0300 webp: Add WebP image decoder plugin https://bugzilla.gnome.org/show_bug.cgi?id=706285
Shouldn't this interpolation be done in the video decoder base class? (The lack of that is causing bugs with jpegdec etc. as well IIRC).
Yes, and there are a few bugs about that already. Let's close this for the WebP support and track the other bug there