After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706207 - MetaWindowActor: fix reference counting issue
MetaWindowActor: fix reference counting issue
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
wayland
Depends on:
Blocks:
 
 
Reported: 2013-08-17 13:56 UTC by Giovanni Campagna
Modified: 2013-08-17 22:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaWindowActor: fix reference counting issue (1.55 KB, patch)
2013-08-17 13:56 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-08-17 13:56:02 UTC 
I have really no idea why nobody noticed this before.
Might be a recent leak fix that uncovered this, or simply nobody
uses the default plugin (and gnome-shell has a GC keeping stuff
alive long after C code is done with it).

Patch for the x11 branch. To be cherry-picked for wayland.
Comment 1 Giovanni Campagna 2013-08-17 13:56:04 UTC 
Created attachment 252019 [details] [review]
MetaWindowActor: fix reference counting issue

We need to use g_signal_connect_object(), rather than g_signal_connect(),
because the window actor can be destroyed before the window emits
the final notify::appears-focused inside unmanage, if the plugin
decides that it doesn't want to animate the destruction (which
happens with dialogs and the default plugin)
Comment 2 drago01 2013-08-17 20:19:16 UTC 
Review of attachment 252019 [details] [review]:

Good catch.
Comment 3 Giovanni Campagna 2013-08-17 22:21:19 UTC 
Attachment 252019 [details] pushed as 506ddc3 - MetaWindowActor: fix reference counting issue