After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706191 - System menu - align submenu labels with parent
System menu - align submenu labels with parent
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-17 11:01 UTC by Allan Day
Modified: 2017-12-11 15:20 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
modified screenshot (169.99 KB, image/png)
2013-08-17 11:01 UTC, Allan Day 		  Details
system: Align submenu labels with parent (2.05 KB, patch)
2017-11-19 19:41 UTC, Florian Müllner 		none Details | Review
system: Align submenu labels with parent (2.10 KB, patch)
2017-12-01 21:34 UTC, Florian Müllner 		committed Details | Review

Description Allan Day 2013-08-17 11:01:46 UTC 
Created attachment 252004 [details]
modified screenshot

The labels for submenu items are much further to the left than the labels for parent menu items. This makes them hard to read, and it looks bad.

The modified screenshot demonstrates the issue.
Comment 1 Giovanni Campagna 2013-08-28 16:16:46 UTC 
The screenshot was missing the icons, so it looked bad for a different reason.
Is this something we still want?
Comment 2 Allan Day 2013-08-28 16:24:12 UTC 
(In reply to comment #1)
> The screenshot was missing the icons, so it looked bad for a different reason.
> Is this something we still want?

Yes, the missing icons was separate.
Comment 3 Matthias Clasen 2013-09-08 17:11:20 UTC 
Not a critical issue, and Jasper says he doesn't plan to fix it for 3.10.
Comment 4 Florian Müllner 2017-11-19 19:41:20 UTC 
Created attachment 364011 [details] [review]
system: Align submenu labels with parent

All section titles use an icon, while all corresponding submenu items
are plain-text. As a result, labels in submenus aren't aligned with
the labels in the parent, which makes them harder to read and look
unbalanced. Address this by adding additional whitespace to submenu
items to account for the additional elements in the title.
Comment 5 Florian Müllner 2017-12-01 21:34:47 UTC 
Created attachment 364788 [details] [review]
system: Align submenu labels with parent

Fix focus/hover highlight in submenus.
Comment 6 Jonas Ådahl 2017-12-11 09:12:07 UTC 
Review of attachment 364788 [details] [review]:

lgtm
Comment 7 Florian Müllner 2017-12-11 15:20:19 UTC 
Attachment 364788 [details] pushed as fb9db4e - system: Align submenu labels with parent