After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706153 - loginDialog: fix session menu visibility
loginDialog: fix session menu visibility
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-16 17:27 UTC by Ray Strode [halfline]
Modified: 2013-08-16 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
loginDialog: fix session menu visibility (2.02 KB, patch)
2013-08-16 17:27 UTC, Ray Strode [halfline] 		needs-work Details | Review
loginDialog: fix session menu visibility (2.02 KB, patch)
2013-08-16 17:56 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2013-08-16 17:27:29 UTC 
The shouldShowSessionMenu function has a few bugs in it.
This fixes them.
Comment 1 Ray Strode [halfline] 2013-08-16 17:27:33 UTC 
Created attachment 251921 [details] [review]
loginDialog: fix session menu visibility
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-16 17:35:53 UTC 
Review of attachment 251921 [details] [review]:

::: js/gdm/loginDialog.js
@@ +605,3 @@
           return false;
 
+        if (this._user && this._user.is_logged_in()

Did you test this patch? This is a syntax error.
Comment 3 Ray Strode [halfline] 2013-08-16 17:53:57 UTC 
I did, then looked at the diff before posting and noticed a trailing whitespace which i cleaned up too thoroughly i guess.
Comment 4 Ray Strode [halfline] 2013-08-16 17:56:49 UTC 
Created attachment 251925 [details] [review]
loginDialog: fix session menu visibility

The shouldShowSessionMenu function has a few bugs in it.
This fixes them.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-08-16 18:05:26 UTC 
Review of attachment 251925 [details] [review]:

OK.
Comment 6 Ray Strode [halfline] 2013-08-16 18:11:49 UTC 
Attachment 251925 [details] pushed as 945b357 - loginDialog: fix session menu visibility