GNOME Bugzilla – Bug 706136
Wi-fi dialog tweaks
Last modified: 2013-08-20 18:37:15 UTC
Created attachment 251843 [details] screenshot Quick design review: * Add 6px horizontal padding between icon and text * Add 12px vertical padding above the list * Place a check mark icon to the right hand side of the connected network (this should always be at the top of the list) * Connect button should remain insensitive if you select the connected network
Created attachment 252236 [details] [review] network: Add a selected indicator to the current access point
Created attachment 252237 [details] [review] network: Make the Connect button insensitive when on the current network
Review of attachment 252236 [details] [review]: ::: js/ui/status/network.js @@ +548,3 @@ + this._signalIcon.icon_name = this._getIcon(); + + if (this._ap == this._device.active_access_point) Uhm... it's a corner case, but the device might be connected to a different, weaker, AP in the same network. I think we want the check mark in that case.
Review of attachment 252237 [details] [review]: ::: js/ui/status/network.js @@ +617,3 @@ + if (this._selectedNetwork) { + let ap = this._selectedNetwork.accessPoints[0]; + connectSensitive = (this._device.active_access_point != ap); Again, the network might be the same, but the APs different.
Created attachment 252238 [details] [review] network: Add a selected indicator to the current access point
Created attachment 252239 [details] [review] network: Make the Connect button insensitive when on the current network
Review of attachment 252238 [details] [review]: Ok
Review of attachment 252239 [details] [review]: Ok
doesn't apply cleanly to current master - can you push this, Jasper ?
I already pushed it; it seems git-bz fell through.