Created attachment 251816 [details] [review]
Add introspection friendly version of gtk_tree_path_new_from_indices

Add gtk_tree_path_new_from_indices_array which takes an array of
integers with a length. Use "Rename to" annotation to rename the
method as gtk_tree_path_new_from_indices. This is needed because
the original method takes variadic arguments which is not supported
by introspection.

Review of attachment 251816 [details] [review]:

the vector variants for variadic arguments function usually follow the naming of "original_function_namev()", so this should be named: "gtk_tree_path_new_indicesv()".

::: gtk/gtktreemodel.c
@@ +697,3 @@
+GtkTreePath *
+gtk_tree_path_new_from_indices_array (gint *indices,
+                                      gint  length)

this should probably be a gsize instead.

@@ +700,3 @@
+{
+  GtkTreePath *path;
+

there should probably be some argument validation, like:

  g_return_val_if_fail (length == 0 && indices != NULL, NULL);

to ensure consistency of both array and length. on the other hand, if you don't want to allow NULL arrays then we should enforce it:

  g_return_val_if_fail (indices != NULL && length != 0, NULL);

Created attachment 251848 [details] [review]
Add introspection friendly version of gtk_tree_path_new_from_indices

Thanks for the review. Updated patch based on comments.

Bump on this? Obviously the available and since tags need to be updated to 3.12.

Created attachment 265093 [details] [review]
Add introspection friendly version of gtk_tree_path_new_from_indices

Updated available in, since, and rename-to annotations.

Review of attachment 265093 [details] [review]:

looks fine to me now. Should just be added to the docs too

Attachment 265093 [details] pushed as efa8956 - Add introspection friendly version of gtk_tree_path_new_from_indices

Thanks, pushed with an additional update to gtk3-sections.txt