After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706092 - fix the look of edit and done buttons
fix the look of edit and done buttons
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-15 22:25 UTC by Yosef Or Boczko
Modified: 2013-08-17 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bump gtk+ and valac required (892 bytes, patch)
2013-08-15 22:25 UTC, Yosef Or Boczko 		committed Details | Review
Contacts.Window: fix the look of edit and done buttons (1.38 KB, patch)
2013-08-15 22:26 UTC, Yosef Or Boczko 		rejected Details | Review
Contacts.Window: fix the look of add button (898 bytes, patch)
2013-08-17 19:06 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2013-08-15 22:25:24 UTC 
See patches.
Comment 1 Yosef Or Boczko 2013-08-15 22:25:47 UTC 
Created attachment 251776 [details] [review]
Bump gtk+ and valac required
Comment 2 Yosef Or Boczko 2013-08-15 22:26:47 UTC 
Created attachment 251777 [details] [review]
Contacts.Window: fix the look of edit and done buttons
Comment 3 Erick Perez Castellanos 2013-08-16 19:54:14 UTC 
Review of attachment 251777 [details] [review]:

Won't be needing this becaus of this https://git.gnome.org/browse/gnome-contacts/commit/?id=42d90effb5f301c05d02348ac2f8ae6b0dfe93f3
Comment 4 Yosef Or Boczko 2013-08-17 19:06:29 UTC 
(In reply to comment #3)
> Review of attachment 251777 [details] [review]:
> 
> Won't be needing this becaus of this
> https://git.gnome.org/browse/gnome-contacts/commit/?id=42d90effb5f301c05d02348ac2f8ae6b0dfe93f3

just in button "select_button" have "<property name="halign">center</property>"
and "<property name="valign">center</property>".
In add_button this lacks.
Comment 5 Yosef Or Boczko 2013-08-17 19:06:55 UTC 
Created attachment 252067 [details] [review]
Contacts.Window: fix the look of add button
Comment 6 Erick Perez Castellanos 2013-08-17 20:01:10 UTC 
Review of attachment 251776 [details] [review]:

Are you sure about this way of specifying the version required for vala ?
Comment 7 Yosef Or Boczko 2013-08-17 20:02:33 UTC 
(In reply to comment #6)
> Review of attachment 251776 [details] [review]:
> 
> Are you sure about this way of specifying the version required for vala ?

Yes. this from 'valac --version', and this very useful to use JHbuild.
Comment 8 Erick Perez Castellanos 2013-08-17 20:27:18 UTC 
An you can close it after that
Comment 9 Yosef Or Boczko 2013-08-17 20:58:22 UTC 
Review of attachment 251776 [details] [review]:

pushed as 00a8535101c8e6ab26d01fed59b608978773057a - Bump gtk+ and valac required