GNOME Bugzilla – Bug 706091
srtpdec: Shadowed variable causes buffers to be dropped
Last modified: 2013-08-16 18:51:46 UTC
Created attachment 251774 [details] [review] Patch that fixes the bug A shadowed variable in request_key_with_signal() causes the return value to always be NULL, which causes buffers to be dropped: 0:00:13.564041677 28969 0x82459b0 DEBUG srtpdec gstsrtpdec.c:448:signal_get_srtp_params:<srtpdec0> Caps received 0:00:13.564167462 28969 0x82459b0 DEBUG srtpdec gstsrtpdec.c:422:get_stream_from_caps: Got key [0xb390de48] 0:00:13.564234299 28969 0x82459b0 INFO srtpdec gstsrtpdec.c:469:init_session_stream:<srtpdec0> Setting RTP policy... 0:00:13.564273772 28969 0x82459b0 INFO srtpdec gstsrtpdec.c:472:init_session_stream:<srtpdec0> Setting RTCP policy... 0:00:13.564348414 28969 0x82459b0 DEBUG srtpdec gstsrtpdec.c:620:request_key_with_signal:<srtpdec0> New stream set with SSRC 2138354990 0:00:13.564398213 28969 0x82459b0 WARN srtpdec gstsrtpdec.c:854:gst_srtp_dec_chain:<srtpdec0> Invalid buffer, dropping 0:00:13.564437928 28969 0x82459b0 WARN srtpdec gstsrtpdec.c:930:gst_srtp_dec_chain:<srtpdec0:rtcp_sink> Dropping buffer 0:00:14.358516438 28969 0x8245a30 WARN basesink gstbasesink.c:3264:gst_base_sink_chain_unlocked:<rtpout> warning: Internal data flow problem. 0:00:14.358592719 28969 0x8245a30 WARN basesink gstbasesink.c:3264:gst_base_sink_chain_unlocked:<rtpout> warning: Received buffer without a new-segment. Assuming timestamps start from 0.
Patch looks good but could you please attach it in "git format-patch" style? For that commit it locally (don't forget to tell git your name and mail address) and then call "git format-patch -1".
Also we would prefer to have your real name to be put into the git commit instead of just a nickname :)
Can you just take credit for it? ;-)
Well, I'm okay with taking credit for a removal of some code, but for additions I would also like your real name. Pushed now, thanks for the patch! commit b8f9d674bef05a4020cef6ab2a53b0f346232444 Author: Tim-Philipp Müller <tim@centricular.net> Date: Fri Aug 16 19:48:03 2013 +0100 srtpdec: fix buffers being dropped due to shadowed variable Spotted by gstblub@gmail.com. https://bugzilla.gnome.org/show_bug.cgi?id=706091