GNOME Bugzilla – Bug 706012
Use virtio-net for gnome-ostree (more generally support hardware choices dependent on OS)
Last modified: 2016-03-31 13:22:07 UTC
I stripped most of the non-virtual hardware drivers out of gnome-ostree; specifically it only comes with virtio for network interfaces. We need to figure out a way to have Boxes more intelligently choose hardware for the guest, maybe this comes down to the OVF thing.
(In reply to comment #0) > I stripped most of the non-virtual hardware drivers out of gnome-ostree; > specifically it only comes with virtio for network interfaces. Now wont be a good time to do this w/ 3.10 almost upon us. > We need to figure out a way to have Boxes more intelligently choose hardware > for the guest, It already does that, based on libosinfo but we dont' have any means to detect OS from an image currently, only ISOs. > maybe this comes down to the OVF thing. Indeed, it does. I intend to work on OVF support in next release cycle.
Created attachment 254538 [details] [review] vm-configurator: Use 'virtio-net' when supported Lets make networking fast when possible. Also this is the first step towards fixing network in gnome ostree images.
Review of attachment 254538 [details] [review]: If this works, it looks quite simple to me. Is this scraping /lib/modules ? Should help for other systems too like Red Hat Enterprise Linux, which is good. Not marking as a-c-n since I don't know the vala code.
(In reply to comment #3) > Review of attachment 254538 [details] [review]: > > If this works, it looks quite simple to me. Is this scraping /lib/modules ? No. I don't really know what you mean. Its only setting virtio-net model in libvirt configuration if virtio-net is supported by the OS. We do the same for virtio-disk. > Should help for other systems too like Red Hat Enterprise Linux, which is good. Yeah, I tested against RHEL.
Review of attachment 254538 [details] [review]: Yup makes sense
Comment on attachment 254538 [details] [review] vm-configurator: Use 'virtio-net' when supported Attachment 254538 [details] pushed as e41bcff - vm-configurator: Use 'virtio-net' when supported
Once bug#707865 is fixed and I add gnome 3.10 to libosinfo, the last step would be to add special code in Boxes to be able to "detect" the (libosinfo's) os and be able to use the right devices and resources etc.
Created attachment 254811 [details] [review] installed-media: Special gnome-continuous images support This patch links gnome-continuous images to appr. libosinfo's OS entry so that Boxes gives it a nice name and assign supported devices. This also fixes the issue of nonfunctional networking in VM created for these images. Ideally we shouldn't need to do this ourselves and libosinfo should do the detection/mapping or we should look into libguestfs for this but that would be a lot of work and it will not be very useful when we add support for OVF files and gnome-continuous start to produce those. So for now we go with this hack, which is not a that bad.
The last patch is only useful once my pending patch to libosinfo is merged.
(In reply to comment #0) > I stripped most of the non-virtual hardware drivers out of gnome-ostree; > specifically it only comes with virtio for network interfaces. Fwiw, it would be nice to have 1 non-virtio net driver if some people attempt to run this on non-kvm hypervisors (vbox comes to mind).
(In reply to comment #10) > (In reply to comment #0) > > I stripped most of the non-virtual hardware drivers out of gnome-ostree; > > specifically it only comes with virtio for network interfaces. > > Fwiw, it would be nice to have 1 non-virtio net driver if some people attempt > to run this on non-kvm hypervisors (vbox comes to mind). From http://www.virtualbox.org/manual/ch06.html#nichardware they claim to support virtio-net...
Attachment 254811 [details] pushed as 223539c - installed-media: Special gnome-continuous images support