After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705986 - audioconvert/audioresample: Add support for non-interleaved audio formats
audioconvert/audioresample: Add support for non-interleaved audio formats
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
playback
Depends on: 751605
Blocks: 705977
 
 
Reported: 2013-08-14 12:25 UTC by Sebastian Dröge (slomo)
Modified: 2018-07-11 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libs: audio-channel-mixer: add support for non-interleaved audio buffers (11.05 KB, patch)
2018-07-03 12:51 UTC, George Kiagiadakis
none Details | Review
libs: audio-resampler: add support for consuming non-interleaved input buffers (2.65 KB, patch)
2018-07-03 12:51 UTC, George Kiagiadakis
none Details | Review
libs: audio-converter: complete code to support non-interleaved audio buffers (9.04 KB, patch)
2018-07-03 12:52 UTC, George Kiagiadakis
none Details | Review
audioconvert: implement support for converting between interleaved and non-interleaved layouts (7.72 KB, patch)
2018-07-03 12:52 UTC, George Kiagiadakis
none Details | Review
tests: audioconvert: add support for specifying the layout on tests (39.22 KB, patch)
2018-07-03 12:53 UTC, George Kiagiadakis
none Details | Review
tests: audioconvert: add tests for planar audio (9.71 KB, patch)
2018-07-03 12:53 UTC, George Kiagiadakis
none Details | Review
audioresample: implement support for non-interleaved buffers (5.69 KB, patch)
2018-07-03 12:54 UTC, George Kiagiadakis
none Details | Review

Description Sebastian Dröge (slomo) 2013-08-14 12:25:34 UTC
+++ This bug was initially created as a clone of Bug #705977 +++

With the upgrade of libav, support for S16 and planar conversions were removed internally and gst-libav now receives the raw planar F32 samples.

For AAC, gst-libav converts the planar F32 samples to interleaved and then audioconvert converts the F32 samples to S16. This is a lot less efficient than the tight single conversion loop that was previously used.

We should:

 - let the audio decoder render planar samples directly into the output buffer
 - make gst-libav output planar formats
 - add support for planar formats in audioconvert and possibly other elements
   that could be used in a typical playbin pipeline
Comment 1 George Kiagiadakis 2018-07-03 12:51:41 UTC
Created attachment 372922 [details] [review]
libs: audio-channel-mixer: add support for non-interleaved audio buffers
Comment 2 George Kiagiadakis 2018-07-03 12:51:57 UTC
Created attachment 372923 [details] [review]
libs: audio-resampler: add support for consuming non-interleaved input buffers
Comment 3 George Kiagiadakis 2018-07-03 12:52:20 UTC
Created attachment 372924 [details] [review]
libs: audio-converter: complete code to support non-interleaved audio buffers
Comment 4 George Kiagiadakis 2018-07-03 12:52:49 UTC
Created attachment 372925 [details] [review]
audioconvert: implement support for converting between interleaved and non-interleaved layouts
Comment 5 George Kiagiadakis 2018-07-03 12:53:19 UTC
Created attachment 372926 [details] [review]
tests: audioconvert: add support for specifying the layout on tests
Comment 6 George Kiagiadakis 2018-07-03 12:53:50 UTC
Created attachment 372927 [details] [review]
tests: audioconvert: add tests for planar audio
Comment 7 George Kiagiadakis 2018-07-03 12:54:12 UTC
Created attachment 372928 [details] [review]
audioresample: implement support for non-interleaved buffers
Comment 8 George Kiagiadakis 2018-07-11 13:45:20 UTC
commit 114f0abbd71e47ab40c3ad3dfd6a83655360eea8
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Wed Feb 7 18:17:07 2018 +0200

    audioresample: implement support for non-interleaved buffers
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705986

commit d57a572172dc95c6737168d6a24dd9c5a5300683
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Fri Feb 9 17:07:48 2018 +0200

    tests: audioconvert: add tests for planar audio
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705986

commit 5c39510905bcd248c9e97815b3d2acaeb3e9418b
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Fri Feb 9 14:29:57 2018 +0200

    tests: audioconvert: add support for specifying the layout on tests
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705986

commit 0eda002cfdf08870d453e394dae7b10eb7c5461f
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Thu Feb 1 18:08:51 2018 +0200

    audioconvert: implement support for converting between interleaved and non-interleaved layouts
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705986

commit 060ecd16cddc7b106c831df7ab4448e121aab085
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Thu Feb 1 17:00:06 2018 +0200

    libs: audio-converter: complete code to support non-interleaved audio buffers
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705986

commit eefdf32d9683ea2fba81156208064fdb2d7c05f3
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Thu Feb 1 13:23:53 2018 +0200

    libs: audio-resampler: add support for consuming non-interleaved input buffers
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705986

commit 108a911610e01dda483a66b667cf1b571fbe0125
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Wed Jan 31 19:28:57 2018 +0200

    libs: audio-channel-mixer: add support for non-interleaved audio buffers
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705986