After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705952 - Format specifier missing in POT file!
Format specifier missing in POT file!
Status: RESOLVED FIXED
Product: easytag
Classification: Other
Component: general
master
Other All
: Normal major
: 2.1
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-14 01:27 UTC by Enrico Nicoletto
Modified: 2013-08-19 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Enrico Nicoletto 2013-08-14 01:27:07 UTC
Good evening,

Please, may sone check what is going on with the last easytag´s POT file released?

In the message below, it is missing a format specifier
"Cannot write tag of file '%s' (%"

It is missing at the end of the sentence!!
............  '%s' (% ....................

Thanks, Enrico.
Comment 1 André Klapper 2013-08-14 07:48:38 UTC
In general please post line number information:

#: ../src/id3v24_tag.c:1493
msgid "Cannot write tag of file '%s' (%"

  Log_Print (LOG_ERROR,
             _("Cannot write tag of file '%s' (%" G_GSSIZE_FORMAT
             " bytes were read but %" G_GSIZE_FORMAT
             " bytes were expected)"),
             basename_utf8, size_read, ctxsize);


Developers: See
https://bugzilla.gnome.org/show_bug.cgi?id=693534
https://bugzilla.gnome.org/show_bug.cgi?id=693535
Comment 2 David King 2013-08-14 08:09:08 UTC
Thanks for the report and links to other bugs. I reworded the string, and constructed it to allow handling of plural forms (as this was missing and not possible with the original string). The fix is in master as commit 3fd5461eda337ef2dacca873e9608e5d393b8375.
Comment 3 Mikael Magnusson 2013-08-19 22:00:16 UTC
+                       ngettext ("Cannot write tag of file '%s' (a byte was missing)",
+                                 "Cannot write tag of file ‘%s’ (%s bytes were missing)",
+                                 ctxsize - size_read),
+                       basename_utf8, bytes_missing);

is what was committed in 3fd546, but note that the second pair of quotes are unicode quotes while the first are ascii. I don't know which you prefer but they should probably not be mixed like that.
Comment 4 David King 2013-08-19 22:43:33 UTC
Thanks, I fixed this in master as commit 
commit 69dbd02480ae2d6503c5cefbe5af30a3e0223feb.