After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705840 - ScreenShield: don't allow events through the lock dialog
ScreenShield: don't allow events through the lock dialog
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 691995 704323 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-08-12 13:16 UTC by Giovanni Campagna
Modified: 2013-08-29 08:24 UTC
See Also:
GNOME target: 3.10
GNOME version: ---


Attachments
ScreenShield: don't allow events through the lock dialog (1.30 KB, patch)
2013-08-12 13:16 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-08-12 13:16:19 UTC
Make the lock dialog group reactive, to intercept any events
before they go to the actors below.
In the future, we may restructure our chrome to have a clear
layer system, but for now it fixes a security issue in the lock
screen (you can see the contents of the windows by dragging
if the screen was locked with the overview active)
Comment 1 Giovanni Campagna 2013-08-12 13:16:22 UTC
Created attachment 251347 [details] [review]
ScreenShield: don't allow events through the lock dialog
Comment 2 Matthias Clasen 2013-08-13 14:54:53 UTC
does this need backporting to 3.8 ?
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-13 15:05:56 UTC
Review of attachment 251347 [details] [review]:

OK.
Comment 4 Giovanni Campagna 2013-08-13 15:11:04 UTC
Attachment 251347 [details] pushed as ef09596 - ScreenShield: don't allow events through the lock dialog
Comment 5 Giovanni Campagna 2013-08-27 08:36:15 UTC
*** Bug 704323 has been marked as a duplicate of this bug. ***
Comment 6 Giovanni Campagna 2013-08-29 08:24:05 UTC
*** Bug 691995 has been marked as a duplicate of this bug. ***