After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705765 - gtkwindow: Export our custom frame extents
gtkwindow: Export our custom frame extents
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 705766
Blocks:
 
 
Reported: 2013-08-10 18:37 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-08-13 14:39 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
gtkwindow: Export our custom frame extents (2.09 KB, patch)
2013-08-10 18:38 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
gtkwindow: Export our custom frame extents (3.59 KB, patch)
2013-08-12 18:55 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-08-10 18:37:58 UTC 
This is for proper CSD support. Currently, we only have integration with mutter, but there's a proposal to standardize this as part of EWMH.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-08-10 18:38:00 UTC 
Created attachment 251272 [details] [review]
gtkwindow: Export our custom frame extents

This allows CSD windows to be maximized, tiled, and constrained
properly.
Comment 2 Matthias Clasen 2013-08-10 21:32:57 UTC 
Review of attachment 251272 [details] [review]:

::: gtk/gtkwindow.c
@@ +6420,3 @@
+    }
+#endif
+}

Should probably go to gdkwindow-x11.c, as gdk_x11_window_set_frame_extents().
Compare gdk_x11_window_set_theme_variant()

@@ +6498,3 @@
                                  priv->title_height;
+
+      update_frame_extents (window, &window_border);

Should you only set this if priv->client_decorated is TRUE ?
Also, do you have to call it in the priv->fullscreen case too, to set the frame extents to 0 ?
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-12 18:55:54 UTC 
Created attachment 251403 [details] [review]
gtkwindow: Export our custom frame extents

This allows CSD windows to be maximized, tiled, and constrained
properly.
Comment 4 Matthias Clasen 2013-08-13 01:20:06 UTC 
Review of attachment 251403 [details] [review]:

Add a doc comment for the new api, and its good to.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-08-13 14:39:28 UTC 
Attachment 251403 [details] pushed as 8818d8a - gtkwindow: Export our custom frame extents