After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705725 - Fix the properties dialog for local collections
Fix the properties dialog for local collections
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.8.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-09 15:21 UTC by Debarshi Ray
Modified: 2013-08-11 06:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
properties: Local collections don't have a path or URI (1.93 KB, patch)
2013-08-09 15:24 UTC, Debarshi Ray 		committed Details | Review
documents: Set the typeDescription for local collections (1.03 KB, patch)
2013-08-09 15:27 UTC, Debarshi Ray 		committed Details | Review
documents: Get rid of redundant string operations (1.77 KB, patch)
2013-08-09 15:31 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-08-09 15:21:15 UTC 
For a number of minor reasons the properties dialog is broken for local collections.
Comment 1 Debarshi Ray 2013-08-09 15:24:42 UTC 
Created attachment 251240 [details] [review]
properties: Local collections don't have a path or URI
Comment 2 Debarshi Ray 2013-08-09 15:27:16 UTC 
Created attachment 251241 [details] [review]
documents: Set the typeDescription for local collections
Comment 3 Debarshi Ray 2013-08-09 15:31:49 UTC 
Created attachment 251242 [details] [review]
documents: Get rid of redundant string operations
Comment 4 Cosimo Cecchi 2013-08-10 14:23:37 UTC 
Review of attachment 251240 [details] [review]:

Looks good
Comment 5 Cosimo Cecchi 2013-08-10 14:24:09 UTC 
Review of attachment 251241 [details] [review]:

Looks good
Comment 6 Cosimo Cecchi 2013-08-10 14:24:44 UTC 
Review of attachment 251242 [details] [review]:

Sure
Comment 7 Debarshi Ray 2013-08-11 06:13:46 UTC 
Thanks for the review.