Created attachment 251012 [details] [review]
sidebar: Port to GtkRevealer and GtkButton

Created attachment 251013 [details] [review]
MainWindow: Port to GtkButton, GtkSearchEntry and GtkHeaderBar

Created attachment 251014 [details] [review]
Remove libgd submodule

Thanks for this work but Mattias was already doing this (bug#703978) so now I must look at both branches and decide on one. :(

Review of attachment 251012 [details] [review]:

Looks really good otherwise.

::: src/sidebar.js
@@ +50,2 @@
         // create the button
+        let revealButton = new Gtk.Button({ child: new Gtk.Image ({ icon_name: prevIconName,

please separate out the Image instantiation in a separate line:

let image = new Gtk.Image...

Created attachment 251052 [details] [review]
sidebar: Port to GtkRevealer and GtkButton

Review of attachment 251013 [details] [review]:

First some nitpicks on commit log:

* Please try to fit the summary in 50 columns/characters so just write "MainWindow: Don't use libgd widgets" in summary.
* Details section can use bullets:

* Gd*Button -> GtkButton
* GdTaggedEntry -> ...

* You'll have to rebase this patch on top of latest git master.

Looks very good otherwise.

Created attachment 251053 [details] [review]
MainWindow: Don't use libgd widgets

Created attachment 251054 [details] [review]
Remove libgd submodule

Thanks for quickly rebasing but I get this error:

(gnome-maps:12302): Gtk-WARNING **: Unknown property: GtkHeaderBar.show-close-button

(gnome-maps:12302): Gtk-WARNING **: Unknown property: GtkHeaderBar.show-close-button

And buttons look broken with your patches.

You have gtk+ from master (3.9.11)?

Created attachment 251065 [details]
Screenshot

Created attachment 251072 [details] [review]
MainWindow: Don't use libgd widgets

Created attachment 251076 [details] [review]
MainWindow: Don't use libgd widgets

Created attachment 251082 [details]
Screenshot

The new style in gtk+.

Attachment 251052 [details] pushed as 6b1db29 - sidebar: Port to GtkRevealer and GtkButton
Attachment 251054 [details] pushed as 28865ed - Remove libgd submodule
Attachment 251076 [details] pushed as 9a41b7d - MainWindow: Don't use libgd widgets

I took the liberty of temporarilly removing the 'titlebar' style class as a) it was messing-up theme at least on my machine and b) It seems unclear whether we should be using this.