GNOME Bugzilla – Bug 705546
Never forgets existing hostname for hotspot
Last modified: 2017-03-10 18:21:22 UTC
Once created, the name of the hotspot never changes. The network shows up in the network panel, and isn't removable.
Created attachment 332224 [details] [review] network: Re-set the SSID when enabling the Hotspot Instead of expecting the hostname to stay the same.
Review of attachment 332224 [details] [review]: looks fine
Attachment 332224 [details] pushed as e824868 - network: Re-set the SSID when enabling the Hotspot
Created attachment 346434 [details] [review] Revert "network: Re-set the SSID when enabling the Hotspot" Re-setting the SSID may be sensible. But that would involve a call to nm_remote_connection_commit_changes_async() to change the connection profile. Just setting the SSID before calling nm_client_activate_connection_async() is wrong as this only changes the local cache of the server-side objects. This reverts commit e8248689762593c3efd03da239303f1aceb1f81a.
The patch e824868 is wrong, and will not fix the original issue. Changing the SSID involves first calling nm_remote_connection_commit_changes_async()
Created attachment 347632 [details] [review] network: Move hotspot connection search into a helper function
Created attachment 347633 [details] [review] network: Save new SSID to disk before enabling the hotspot Commit e824868 was supposed to do this, but needed to write the changes out to disk before activating the hotspot.
(In reply to Thomas Haller from comment #5) > The patch e824868 is wrong, and will not fix the original issue. > > Changing the SSID involves first calling > nm_remote_connection_commit_changes_async() Sending out a "revert" patch instead of fixing the problem doesn't really help me. The patches above aren't tested (yet).
Created attachment 347663 [details] [review] network: Save new SSID to disk before enabling the hotspot Commit e824868 was supposed to do this, but needed to write the changes out to disk before activating the hotspot.
Created attachment 347664 [details] [review] network: Fix initial state of Wi-Fi device This ensures that: - the AP list shown on startup when the Hotspot is disabled on startup, or when disabling it at run-time - the hotspot page is shown on startup when the Hotspot is enabled, or when it gets enabled at runtime
Attachment 347632 [details] pushed as 277ac7d - network: Move hotspot connection search into a helper function Attachment 347663 [details] pushed as 700e5e5 - network: Save new SSID to disk before enabling the hotspot Attachment 347664 [details] pushed as c7800dd - network: Fix initial state of Wi-Fi device
Also pushed to gnome-3-22