After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705464 - Rename box displayed at wrong location when scrolling
Rename box displayed at wrong location when scrolling
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
3.10.x
Other Linux
: High major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 707415 710910 711302 711502 730221 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-08-04 21:37 UTC by Mantas Mikulėnas (grawity)
Modified: 2014-05-16 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix rename entry position (1.53 KB, patch)
2013-11-04 15:49 UTC, Alexander Larsson
committed Details | Review

Description Mantas Mikulėnas (grawity) 2013-08-04 21:37:12 UTC
Exactly like bug 686322, except this time it's for Nautilus 3.9.3-git... If the file list (in icon view) is scrolled down, then the rename textbox is displayed in the wrong location. The more I scroll, the larger is the distance between the correct and actual position.

(I wasn't sure if I should post a new bug report or reopen the old one...)

nautilus 3.9.3.r47.g3a6053f
gtk3 3.9.10.r50.ga4d9e92
Comment 1 Nelson Benitez 2013-09-06 17:54:23 UTC
I can reproduce this with today's nautilus master, pretty ugly bug, I think this should be a showstopper for nautilus 3.10
Comment 2 Nelson Benitez 2013-09-06 18:02:38 UTC
*** Bug 707415 has been marked as a duplicate of this bug. ***
Comment 3 Nelson Benitez 2013-09-09 18:38:50 UTC
As per my tests, this bug is caused by some component outside of nautilus (possibly a gtk+ change triggers it) because nautilus-3.8.2 that comes in my fedora 19 does not have the bug, while a compiled nautilus-3.8.2 that runs in jhbuild (where rest of packages have master or very up-to-date versions) do have the bug.
Comment 4 Nelson Benitez 2013-09-11 07:32:17 UTC
(In reply to comment #3)
> As per my tests, this bug is caused by some component outside of nautilus
> (possibly a gtk+ change triggers it) because nautilus-3.8.2 that comes in my
> fedora 19 does not have the bug, while a compiled nautilus-3.8.2 that runs in
> jhbuild (where rest of packages have master or very up-to-date versions) do
> have the bug.

I confirmed my suspicions, after an afternoon jhbuilding different gtk+ versions, I found the gtk+ commit that produces the bug, it's from 2013-05-07 and first appeared in gtk+-3.9.2, it's this:

https://git.gnome.org/browse/gtk+/commit/?id=d22fd7223c75f4720ddb982c659efb0d8d7543c4


which is a non trivial patch from alexl that changes how gtk+ internal draw mechanism works.

So maybe alex and other people who understand that code could look at the eel-editable-label.c draw function to check if it's in sync with those gtk+ draw changes?

https://git.gnome.org/browse/nautilus/tree/eel/eel-editable-label.c#n1494

as that is the only thing I can think of as causing the bug.
Comment 5 Matthew Wardrop 2013-10-03 00:52:23 UTC
Has a bug for this been filed against GTK? This is quite crippling.
Comment 6 Matthew Wardrop 2013-10-08 22:21:25 UTC
Is there any chance of this being fixed by 3.10.1? It is kind of hard to recommend nautilus as a file manager (which I like to do) while you cannot reliably rename files ><.
Comment 7 António Fernandes 2013-10-26 09:21:13 UTC
*** Bug 710910 has been marked as a duplicate of this bug. ***
Comment 8 António Fernandes 2013-10-26 09:29:54 UTC
CC'ing alexl for the question on comment 4.
Comment 9 António Fernandes 2013-11-02 20:10:44 UTC
*** Bug 711302 has been marked as a duplicate of this bug. ***
Comment 10 Alexander Larsson 2013-11-04 15:49:54 UTC
Created attachment 258937 [details] [review]
Fix rename entry position

We need to not modify the cairo_t when we propagate up to the parent class
as this affects where GtkLayout draws the child widgets.
Comment 11 Alexander Larsson 2013-11-04 15:52:30 UTC
Attachment 258937 [details] pushed as 481cf68 - Fix rename entry position
Comment 12 Alexander Larsson 2013-11-04 15:55:21 UTC
Pushed this to master and gnome-3-10, but we probably need a 3.10 release with this...
Comment 13 Alexander Larsson 2013-11-04 16:24:28 UTC
3.10.1 out
Comment 14 António Fernandes 2013-11-05 17:59:41 UTC
*** Bug 711502 has been marked as a duplicate of this bug. ***
Comment 15 Paul Menzel 2014-05-16 20:38:55 UTC
*** Bug 730221 has been marked as a duplicate of this bug. ***