After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705378 - build fails due to missing IT_PROG_INTLTOOL macro
build fails due to missing IT_PROG_INTLTOOL macro
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2013-08-02 19:52 UTC by Seán de Búrca
Modified: 2013-08-27 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to allow macros to be copied automatically into build directory (792 bytes, patch)
2013-08-02 19:52 UTC, Seán de Búrca
none Details | Review
Patch to fix build (1.03 KB, patch)
2013-08-26 08:44 UTC, Seán de Búrca
committed Details | Review

Description Seán de Búrca 2013-08-02 19:52:12 UTC
Created attachment 250737 [details] [review]
Patch to allow macros to be copied automatically into build directory

When running autogen.sh in master, the intltool.m4 macro is never included in
aclocal.m4. Attached is a patch to fix this by having gnome-autogen.sh create
an m4/ directory and copy over the correct macros. I can commit it if it is
approved.

I believe this is due to a change in the behavior of gnome-common (using autoreconf instead of replicating its behavior). According to the autoconf documentation, I believe this patch is the correct behavior.
Comment 1 Seán de Búrca 2013-08-26 08:44:37 UTC
Created attachment 253098 [details] [review]
Patch to fix build

Per https://bugzilla.gnome.org/show_bug.cgi?id=705365, using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT is unsupported. This patch extends the previous one to remove AM_GNU_GETTEXT to fix build.
Comment 2 David King 2013-08-27 14:50:35 UTC
Review of attachment 253098 [details] [review]:

The change looks fine to me (as a gnome-common maintainer), but please add a descriptive commit message link to this bug in the commit message before pushing.